chrome/test/functional/instant.py - Issue 7544026: Fix for flakiness in pyauto automation hook WaitForDownloadsToComplete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/instant.py

Issue 7544026: Fix for flakiness in pyauto automation hook WaitForDownloadsToComplete. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-wrote the first patch set. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/functional/instant.py

diff --git a/chrome/test/functional/instant.py b/chrome/test/functional/instant.py

index 796b68754389f4ef6b1e24ff8c5d9fcb58f330e8..aa5311aa280e964c63e9753479c8f1d877ff34c1 100644

--- a/chrome/test/functional/instant.py

+++ b/chrome/test/functional/instant.py

@@ -229,7 +229,7 @@ class InstantTest(pyauto.PyUITest):

filepath = self.GetFileURLForDataPath(path)

self.SetOmniboxText(filepath)

self.WaitUntilOmniboxQueryDone()

- self.WaitForAllDownloadsToComplete()

+ self.WaitForAllDownloadsToComplete([])

self.assertFalse(self.GetDownloadsInfo().Downloads(),

msg='Should not download: %s' % filepath)