Print preview page selection should not require a rerendering of draft pages.

chrome/renderer/print_web_view_helper.h

Index: chrome/renderer/print_web_view_helper.h
diff --git a/chrome/renderer/print_web_view_helper.h b/chrome/renderer/print_web_view_helper.h
index 4606c3716217f3d8db447e0272f6be95999e3217..3f1098d0cd87b3dda1dd2b0cf94b99b7f08ffaa6 100644
--- a/chrome/renderer/print_web_view_helper.h
+++ b/chrome/renderer/print_web_view_helper.h
@@ -6,7 +6,6 @@
 #define CHROME_RENDERER_PRINT_WEB_VIEW_HELPER_H_
 #pragma once
 
-#include <utility>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ -135,10 +134,8 @@ class PrintWebViewHelper : public RenderViewObserver,
   // Initialize the print preview document.
   bool CreatePreviewDocument();
 
-  // Continue generating the print preview. |requested_preview_page_index|
-  // specifies the browser requested preview page index. It is 1-based or
-  // |printing::INVALID_PAGE_INDEX| to continue with next page.
-  void OnContinuePreview(int requested_preview_page_index);
+  // Continue generating the print preview.
+  void OnContinuePreview();
   // Renders a print preview page. |page_number| is 0-based.
   void RenderPreviewPage(int page_number);
   // Finalize the print preview document.
@@ -292,6 +289,7 @@ class PrintWebViewHelper : public RenderViewObserver,
 
   scoped_ptr<PrintMsg_PrintPages_Params> print_pages_params_;
   bool is_preview_;
+  bool is_complete_metafile_already_sent_;
 
   // Used for scripted initiated printing blocking.
   base::Time last_cancelled_script_print_;
@@ -326,7 +324,7 @@ class PrintWebViewHelper : public RenderViewObserver,
     void RenderedPreviewPage(const base::TimeDelta& page_time);
 
     // Finalizes the print preview document.
-    void FinalizePreviewDocument();
+    void FinalizePreviewDocument(bool is_complete_metafile_already_sent);
 
     // Cleanup after print preview finishes.
     void Finished();
@@ -339,6 +337,14 @@ class PrintWebViewHelper : public RenderViewObserver,
     bool IsReadyToRender() const;
     bool IsBusy() const;
     bool IsModifiable() const;
+    bool IsCompleteMetafileReady() const;
+
+    void set_generate_draft_pages(bool generate_draft_pages) {
+      generate_draft_pages_ = generate_draft_pages;

[vandebo (ex-Chrome), 2011/08/03 20:48:21]

Put the implementation in the .cc and move this down with the rest of the
getters

[kmadhusu, 2011/08/04 20:47:53]

Done.

+    }
+    bool generate_draft_pages() {
+      return generate_draft_pages_;
+    }
 
     // Getters
     WebKit::WebFrame* frame() const;
@@ -370,16 +376,17 @@ class PrintWebViewHelper : public RenderViewObserver,
     // Total page count in the renderer.
     int total_page_count_;
 
-    // Number of pages to render.
-    int actual_page_count_;
+    // Store the preview page index list.

[vandebo (ex-Chrome), 2011/08/03 20:48:21]

This comment is opaque, I'm not even sure what it means.

[kmadhusu, 2011/08/04 20:47:53]

Fixed.

+    std::vector<int> render_page_list_;
+
+    // True, when draft pages needs to be generated.
+    bool generate_draft_pages_;
 
-    // The current page to render.
-    int current_page_number_;
+    // Specifies the total number of pages in complete metafile.
+    int complete_metafile_page_count_;
 
-    // |rendered_pages_| tracks which pages need to be printed as well as
-    // the page slot it should be printed in. See GetPageSlotForPage.
-    typedef std::pair<bool, int> PreviewPageInfo;
-    std::vector<PreviewPageInfo> rendered_pages_;
+    // Specifies the current list index.

[vandebo (ex-Chrome), 2011/08/03 20:48:21]

Probably best to put this next to render_page_list

[kmadhusu, 2011/08/04 20:47:53]

Done.

+    int render_page_list_index_;
 
     base::TimeDelta document_render_time_;
     base::TimeTicks begin_time_;