Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4400)

Unified Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 7544018: Print preview page selection should not require a rerendering of draft pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_message_handler.cc
diff --git a/chrome/browser/printing/print_preview_message_handler.cc b/chrome/browser/printing/print_preview_message_handler.cc
index d2b11813c98f09fd4b2e2da1fa898c80b2dc39ad..0c8d15b5e543f181b92a33964882518b732a7a07 100644
--- a/chrome/browser/printing/print_preview_message_handler.cc
+++ b/chrome/browser/printing/print_preview_message_handler.cc
@@ -80,9 +80,11 @@ void PrintPreviewMessageHandler::OnRequestPrintPreview() {
PrintPreviewTabController::PrintPreview(tab_contents());
}
-void PrintPreviewMessageHandler::OnDidGetPreviewPageCount(int document_cookie,
- int page_count,
- bool is_modifiable) {
+void PrintPreviewMessageHandler::OnDidGetPreviewPageCount(
+ int document_cookie,
+ int page_count,
+ bool is_modifiable,
+ bool clear_preview_data) {
if (page_count <= 0)
return;
TabContents* print_preview_tab = GetPrintPreviewTab();
@@ -91,6 +93,10 @@ void PrintPreviewMessageHandler::OnDidGetPreviewPageCount(int document_cookie,
PrintPreviewUI* print_preview_ui =
static_cast<PrintPreviewUI*>(print_preview_tab->web_ui());
+
+ if (!is_modifiable || clear_preview_data)
+ print_preview_ui->ClearAllPreviewData();
+
print_preview_ui->OnDidGetPreviewPageCount(
document_cookie, page_count, is_modifiable);
}
@@ -116,12 +122,7 @@ void PrintPreviewMessageHandler::OnDidPreviewPage(
return;
}
- int requested_preview_page_index = INVALID_PAGE_INDEX;
int page_number = params.page_number;
-
- if (page_number == FIRST_PAGE_INDEX)
- print_preview_ui->ClearAllPreviewData();
-
if (page_number >= FIRST_PAGE_INDEX && params.data_size) {
RefCountedBytes* data_bytes =
GetDataFromHandle(params.metafile_data_handle, params.data_size);
@@ -129,12 +130,9 @@ void PrintPreviewMessageHandler::OnDidPreviewPage(
print_preview_ui->SetPrintPreviewDataForIndex(page_number, data_bytes);
print_preview_ui->OnDidPreviewPage(page_number);
- // TODO(kmadhusu): Query |PrintPreviewUI| and update
- // |requested_preview_page_index| accordingly.
}
- rvh->Send(new PrintMsg_ContinuePreview(rvh->routing_id(),
- requested_preview_page_index));
+ rvh->Send(new PrintMsg_ContinuePreview(rvh->routing_id()));
}
void PrintPreviewMessageHandler::OnPagesReadyForPreview(

Powered by Google App Engine
This is Rietveld 408576698