Implement type recording for ToBoolean on x64.

src/code-stubs.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 937 matching lines @@
  private:
   Major MajorKey() { return ToBoolean; }
   int MinorKey() { return (tos_.code() << NUMBER_OF_TYPES) | types_.ToByte(); }
 
   virtual void FinishCode(Code* code) {
     code->set_to_boolean_state(types_.ToByte());
   }
 
   void CheckOddball(MacroAssembler* masm,
                     Type type,
+#if V8_TARGET_ARCH_IA32

[danno, 2011/08/01 11:36:13]

Why don't you make CheckOddball a method in the MacroAssembler? Then you don't
need the #if def at all

[Kevin Millikin (Chromium), 2011/08/01 11:51:55]

I thought it was because it needs the types_.  They could be passed in as an
argument, but the function is still pretty specific to this stub.

                     Handle<Object> value,

[Kevin Millikin (Chromium), 2011/08/01 11:32:04]

I don't really like using the preprocessor like this.  Couldn't it be avoided by
passing the root list index always and using the roots array in the IA32
implementation?

+#else
+                    Heap::RootListIndex value,
+#endif
                     bool result,
                     Label* patch);
   void GenerateTypeTransition(MacroAssembler* masm);
 
   Register tos_;
   Types types_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODE_STUBS_H_