Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: Source/WebCore/ChangeLog

Issue 7542020: Merge 91725 - REGRESSION (r39725?): Resources removed from document can not be freed until the do... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/loader/cache/CachedResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 92201)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,1537 +1,3 @@
-2011-07-28 Rob Buis <rbuis@rim.com>
-
- REGRESSION (r91125): Google Drawings is broken
- https://bugs.webkit.org/show_bug.cgi?id=65257
-
- Reviewed by Darin Adler.
-
- Only consider zero-length path rendering code path when a stroke is defined.
-
- Test: svg/custom/zero-path-square-cap-rendering2.svg
-
- * rendering/svg/RenderSVGPath.cpp:
- (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
-
-2011-07-22 Martin Robinson <mrobinson@igalia.com>
-
- [Cairo] Switch from ContextShadow to ShadowBlur
- https://bugs.webkit.org/show_bug.cgi?id=64744
-
- Use ShadowBlur in the Cairo backend instead of ContextShadow. This allows us
- to share shadowing code with Qt and Mac ports and to correct some broken
- shadow rendering.
-
- Reviewed by Dirk Schulze.
-
- * CMakeLists.txt: Remove ContextShadow from the build.
- * CMakeListsEfl.txt: Ditto.
- * GNUmakefile.list.am: Add ShadowBlur source files and remove ContextShadow
- source files.
- * platform/graphics/GraphicsContext.cpp:Add #ifdefs to support ShadowBlur for Cairo.
- * platform/graphics/GraphicsContext.h: Remove Cairo ContextShadow code.
- * platform/graphics/ShadowBlur.cpp:
- (WebCore::ShadowBlur::drawInsetShadowWithTiling): Since the ShadowBlur is a property
- of the GraphicsContext, we cannot clear the GraphicsContext shadow until we have
- finished using properties like m_offset. If we clear the GrahpicsContext shadow
- before using these properties, they will be zero when we try to use them.
- (WebCore::ShadowBlur::drawRectShadowWithTiling):Ditto.
- (WebCore::ShadowBlur::drawLayerPieces): Ditto.
- (WebCore::ShadowBlur::beginShadowLayer):Cairo is the first port to keep ShadowBlur
- as a persistent property of GraphicsContext and use drawRectShadow and drawInsetShadow.
- Thus, we must manually clear the cached tiling values so that ShadowBlur does not
- try to reuse the scratch buffer for rectangular shadows after using beginShadowLayer
- and endShadowLayer.
- (WebCore::ShadowBlur::mustUseShadowBlur): Moved this method from the Qt port to
- this cross-platform location.
- * platform/graphics/ShadowBlur.h: Added new method declaration.
- * platform/graphics/cairo/ContextShadowCairo.cpp: Removed.
- * platform/graphics/cairo/FontCairo.cpp: Switched to using ShadowBlur.
- (WebCore::drawGlyphsShadow):Ditto.
- * platform/graphics/cairo/GraphicsContextCairo.cpp: Switch to using ShadowBlur.
- (WebCore::drawPathShadow): ShadowBlur has slightly different semantics than
- ContextShadow. When filling the shadow layer, we do not need to use the fill
- alpha. We also need to restore the Cairo path to the target context after
- endShadowLayer as it destroys the current path.
- * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Switch to using ShadowBlur.
- * platform/graphics/cairo/ImageCairo.cpp: Ditto.
- * platform/graphics/cairo/PlatformContextCairo.cpp:
- (WebCore::PlatformContextCairo::drawSurfaceToContext):Ditto.
- (WebCore::PlatformContextCairo::prepareForStroking): Add a mode ignoring alpha.
- * platform/graphics/cairo/PlatformContextCairo.h: Ditto.
- (WebCore::PlatformContextCairo::shadowBlur):Added.
- * platform/graphics/gtk/FontGtk.cpp: Update to use ShadowBlur.
- * platform/graphics/qt/GraphicsContextQt.cpp: Switch to using the new version of mustUseShadowBlur.
-
-2011-07-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
-
- [EFL] Add dummy NotificationPresenterClientEfl
- https://bugs.webkit.org/show_bug.cgi?id=64064
-
- Add two files to CMakeLists.txt for HTML5 Notification.
-
- Reviewed by Antonio Gomes.
-
- * CMakeLists.txt:
-
-2011-07-27 Ryosuke Niwa <rniwa@webkit.org>
-
- Calling window.find immediately after mutating the document crashes WebKit.
- https://bugs.webkit.org/show_bug.cgi?id=65296
-
- Reviewed by Darin Adler.
-
- Don't forget to layout first.
-
- Test: editing/text-iterator/find-after-mutation.html
-
- * editing/TextIterator.cpp:
- (WebCore::findPlainText):
-
-2011-07-27 Ben Wells <benwells@chromium.org>
-
- Remove skia special case for outline rendering code
- https://bugs.webkit.org/show_bug.cgi?id=65295
-
- Reviewed by James Robinson.
-
- The fix for bug 58999 (outlines with alpha channels showed artifacts in the corners) was
- excluded from skia builds until bug 61369 (skia drawConvexPoly didn't pay attention to
- shouldAntialias) was fixed. That bug is fixed so now the #if's can be removed.
-
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::paintOutline):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::paintOutline):
-
-2011-07-27 Adam Barth <abarth@webkit.org>
-
- Crypto.idl doesn't need legacy optional arguments
- https://bugs.webkit.org/show_bug.cgi?id=65298
-
- Reviewed by Darin Adler.
-
- This API is relatively new and useless to call without its only argument.
-
- * page/Crypto.idl:
-
-2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
-
- Remove operator new from JSCell
- https://bugs.webkit.org/show_bug.cgi?id=64999
-
- Reviewed by Oliver Hunt.
-
- No new tests.
-
- Removed the implementation of operator new in JSCell, so any further uses
- will not successfully link. Also removed any remaining uses of operator new.
-
- * bridge/c/CRuntimeObject.h:
- (JSC::Bindings::CRuntimeObject::create):
- * bridge/c/c_instance.cpp:
- (JSC::Bindings::CInstance::newRuntimeObject):
- (JSC::Bindings::CRuntimeMethod::create):
- (JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
- (JSC::Bindings::CInstance::getMethod):
- * bridge/jni/jsc/JavaInstanceJSC.cpp:
- (JavaInstance::newRuntimeObject):
- (JavaRuntimeMethod::create):
- (JavaRuntimeMethod::JavaRuntimeMethod):
- (JavaInstance::getMethod):
- * bridge/jni/jsc/JavaRuntimeObject.h:
- (JSC::Bindings::JavaRuntimeObject::create):
- * bridge/objc/ObjCRuntimeObject.h:
- (JSC::Bindings::ObjCRuntimeObject::create):
- * bridge/objc/objc_class.mm:
- (JSC::Bindings::ObjcClass::fallbackObject):
- * bridge/objc/objc_instance.mm:
- (ObjcInstance::newRuntimeObject):
- (ObjCRuntimeMethod::create):
- (ObjCRuntimeMethod::ObjCRuntimeMethod):
- (ObjcInstance::getMethod):
- * bridge/objc/objc_runtime.h:
- (JSC::Bindings::ObjcFallbackObjectImp::create):
-
-2011-07-27 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Network panel sidebar should have width saved in preferences when resource is selected.
- https://bugs.webkit.org/show_bug.cgi?id=65256
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/NetworkPanel.js:
- (WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
- (WebInspector.NetworkPanel.prototype.restoreSidebarWidth):
- (WebInspector.NetworkPanel.prototype._showResource):
- (WebInspector.NetworkPanel.prototype._closeVisibleResource):
- (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
- * inspector/front-end/Panel.js:
- (WebInspector.Panel.prototype.show):
- (WebInspector.Panel.prototype.preferredSidebarWidth):
- (WebInspector.Panel.prototype.get restoreSidebarWidth):
-
-2011-07-27 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
- https://bugs.webkit.org/show_bug.cgi?id=65279
-
- Reviewed by Pavel Feldman.
-
- * inspector/InspectorPageAgent.cpp:
- (WebCore::InspectorPageAgent::open):
-
-2011-07-27 Adam Klein <adamk@chromium.org>
-
- [V8] Remove unused m_isWeak member of V8AbstractEventListener
- https://bugs.webkit.org/show_bug.cgi?id=65273
-
- Reviewed by Adam Barth.
-
- m_isWeak is set to true in the constructor and never changed,
- so the one if statement that tests it always executes; the
- code has been updated to make this clear.
-
- No behavior change, thus no tests.
-
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::V8AbstractEventListener):
- (WebCore::V8AbstractEventListener::setListenerObject):
- * bindings/v8/V8AbstractEventListener.h:
-
-2011-07-27 Fady Samuel <fsamuel@chromium.org>
-
- Popups on Chromium now check the minimum row height set through the Chromium WebKit API when
- computing the height of a row in a popup listbox.
- https://bugs.webkit.org/show_bug.cgi?id=64897
-
- Reviewed by Darin Fisher.
-
- No new tests.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::getRowHeight):
- * platform/chromium/PopupMenuChromium.h:
- (WebCore::PopupMenuChromium::minimumRowHeight):
- (WebCore::PopupMenuChromium::setMinimumRowHeight):
-
-2011-07-27 MORITA Hajime <morrita@google.com>
-
- Inconsistent state of TreeScope reference.
- https://bugs.webkit.org/show_bug.cgi?id=65235
-
- The tree scope pointers on shadow tree nodes didn't cleared.
- even when the tree scope (shadow root) is destroyed.
- This change clear these poitners before detaching the shadow root.
-
- Reviewed by Dimitri Glazkov.
-
- Test: fast/dom/shadow/tree-scope-crash.html
-
- * dom/Element.cpp:
- (WebCore::Element::removeShadowRoot):
-
-2011-07-27 Rachel Blum <groby@chromium.org>
-
- Implement sizes attribute for link tag from HTML5
- https://bugs.webkit.org/show_bug.cgi?id=37674
-
- Reviewed by Dimitri Glazkov.
-
- Test: fast/dom/icon-size-property.html
-
- * WebCore.gypi:
- * WebCore.pro:
- * bindings/js/JSHTMLLinkElementCustom.cpp:
- (WebCore::JSHTMLLinkElement::sizes):
- (WebCore::JSHTMLLinkElement::setSizes):
- * bindings/v8/custom/V8HTMLLinkElementCustom.cpp: Added.
- (WebCore::V8HTMLLinkElement::sizesAccessorGetter):
- (WebCore::V8HTMLLinkElement::sizesAccessorSetter):
- * html/HTMLAttributeNames.in:
- * html/HTMLLinkElement.cpp:
- (WebCore::HTMLLinkElement::HTMLLinkElement):
- (WebCore::HTMLLinkElement::parseMappedAttribute):
- (WebCore::HTMLLinkElement::sizes):
- (WebCore::HTMLLinkElement::setSizes):
- * html/HTMLLinkElement.h:
- * html/HTMLLinkElement.idl:
-
-2011-07-27 Pratik Solanki <psolanki@apple.com>
-
- Incorrect arguments passed to LOG statement
- https://bugs.webkit.org/show_bug.cgi?id=65293
-
- Reviewed by Oliver Hunt.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):
-
-2011-07-27 Levi Weintraub <leviw@chromium.org>
-
- Switch transform operations to FloatSize
- https://bugs.webkit.org/show_bug.cgi?id=64301
-
- Reviewed by Simon Fraser.
-
- Changing TransformOperation and its progeny to operate on FloatSizes instead of IntSizes.
-
- * platform/graphics/transforms/IdentityTransformOperation.h:
- (WebCore::IdentityTransformOperation::apply):
- * platform/graphics/transforms/Matrix3DTransformOperation.cpp:
- (WebCore::Matrix3DTransformOperation::blend):
- * platform/graphics/transforms/Matrix3DTransformOperation.h:
- (WebCore::Matrix3DTransformOperation::apply):
- * platform/graphics/transforms/MatrixTransformOperation.cpp:
- (WebCore::MatrixTransformOperation::blend):
- * platform/graphics/transforms/MatrixTransformOperation.h:
- (WebCore::MatrixTransformOperation::apply):
- * platform/graphics/transforms/PerspectiveTransformOperation.h:
- (WebCore::PerspectiveTransformOperation::apply):
- * platform/graphics/transforms/RotateTransformOperation.h:
- (WebCore::RotateTransformOperation::apply):
- * platform/graphics/transforms/ScaleTransformOperation.h:
- (WebCore::ScaleTransformOperation::apply):
- * platform/graphics/transforms/SkewTransformOperation.h:
- (WebCore::SkewTransformOperation::apply):
- * platform/graphics/transforms/TransformOperation.h:
- * platform/graphics/transforms/TransformOperations.h:
- (WebCore::TransformOperations::apply):
- * platform/graphics/transforms/TranslateTransformOperation.h:
- (WebCore::TranslateTransformOperation::x):
- (WebCore::TranslateTransformOperation::y):
- (WebCore::TranslateTransformOperation::z):
- (WebCore::TranslateTransformOperation::apply):
-
-2011-07-27 Levi Weintraub <leviw@chromium.org>
-
- unicode-bidi:-webkit-plaintext does not work on <textarea>
- https://bugs.webkit.org/show_bug.cgi?id=65074
-
- Reviewed by Ryosuke Niwa.
-
- Fixing unicode-bidi style propagation into text control shadow trees.
-
- Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html
-
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::adjustInnerTextStyle):
-
-2011-07-27 Eric Carlson <eric.carlson@apple.com>
-
- Load delegate not consulted before loading some poster images
- https://bugs.webkit.org/show_bug.cgi?id=65270
-
- Reviewed by Darin Adler.
-
- Test: media/video-poster-blocked-by-willsendrequest.html
-
- * html/HTMLVideoElement.cpp:
- (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if
- willLoadMediaElementURL returns false.
-
-2011-07-27 Stephen White <senorblanco@chromium.org>
-
- Fix for printing with accelerated <canvas>
- https://bugs.webkit.org/show_bug.cgi?id=62406
-
- Reviewed by James Robinson.
-
- The platform-independent side of this should be covered by existing
- tests. Printing itself in Chrome has few tests, sadly. :(
-
- * html/HTMLCanvasElement.cpp:
- (WebCore::HTMLCanvasElement::paint):
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::draw):
-
-2011-07-25 Mihai Parparita <mihaip@chromium.org>
-
- [Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
- https://bugs.webkit.org/show_bug.cgi?id=65158
-
- Reviewed by David Hyatt.
-
- Add per-Document instance user stylesheets (as opposed to the page
- group user styles and the global page stylesheet).
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::CSSStyleSelector):
- * css/CSSStyleSelector.h:
- * dom/Document.cpp:
- (WebCore::Document::~Document):
- (WebCore::Document::createStyleSelector):
- (WebCore::Document::addUserSheet):
- * dom/Document.h:
-
-2011-07-27 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Disable cache option should only clear memory cache, not disable it.
- https://bugs.webkit.org/show_bug.cgi?id=65184
-
- Reviewed by Pavel Feldman.
-
- * inspector/InspectorClient.h:
- * inspector/InspectorResourceAgent.cpp:
- (WebCore::InspectorResourceAgent::enable):
- (WebCore::InspectorResourceAgent::disable):
- (WebCore::InspectorResourceAgent::setCacheDisabled):
- (WebCore::InspectorResourceAgent::mainFrameNavigated):
-
-2011-07-27 Rob Buis <rbuis@rim.com>
-
- Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
- https://bugs.webkit.org/show_bug.cgi?id=11274
-
- Reviewed by Nikolas Zimmermann.
-
- Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
- The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
- pointer-events=none in the list.
-
- Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg
- svg/custom/intersection-list-clipping.svg
- svg/custom/intersection-list-nested-svg.svg
-
- * rendering/svg/RenderSVGModelObject.cpp:
- (WebCore::getElementCTM):
- (WebCore::intersectsAllowingEmpty):
- (WebCore::isGraphicsElement):
- (WebCore::RenderSVGModelObject::checkIntersection):
- (WebCore::RenderSVGModelObject::checkEnclosure):
- * rendering/svg/RenderSVGModelObject.h:
- * svg/SVGSVGElement.cpp:
- (WebCore::SVGSVGElement::checkIntersection):
- (WebCore::SVGSVGElement::checkEnclosure):
-
-2011-07-27 Becsi Andras <abecsi@webkit.org>
-
- [Qt][V8] Fix the build.
-
- Unreviewed build fix.
-
- No new tests needed.
-
- * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.
-
-2011-07-27 Alexis Menard <alexis.menard@openbossa.org>
-
- [Qt] Unreviewed build fix for mac.
-
- QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
- of the options passed to build-webkit, therefore DerivedSources should now generate the
- includes when it's mac.
-
- * DerivedSources.pro:
- * WebCore.pro:
-
-2011-07-27 Yury Semikhatsky <yurys@chromium.org>
-
- Inspector should support cd(window) in the command line
- https://bugs.webkit.org/show_bug.cgi?id=19872
-
- Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.
-
- Reviewed by Pavel Feldman.
-
- Test: http/tests/inspector/console-cd.html
-
- * WebCore.gypi:
- * inspector/Inspector.json:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorRuntimeAgent.cpp:
- (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- (WebCore::InspectorRuntimeAgent::evaluate):
- * inspector/InspectorRuntimeAgent.h:
- * inspector/WorkerInspectorController.cpp:
- * inspector/front-end/ConsoleView.js:
- (WebInspector.ConsoleView.prototype.addContext):
- (WebInspector.ConsoleView.prototype.removeContext):
- (WebInspector.ConsoleView.prototype._contextUpdated):
- (WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
- (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- * inspector/front-end/ContextManager.js: Added.
- (WebInspector.ContextManager):
- (WebInspector.ContextManager.prototype._frameAdded):
- (WebInspector.ContextManager.prototype._frameNavigated):
- (WebInspector.ContextManager.prototype._frameDetached):
- (WebInspector.FrameEvaluationContext):
- (WebInspector.FrameEvaluationContext.prototype._frameNavigated):
- (WebInspector.FrameEvaluationContext.prototype.get id):
- (WebInspector.FrameEvaluationContext.prototype.get url):
- (WebInspector.FrameEvaluationContext.prototype.get displayName):
- * inspector/front-end/ResourceTreeModel.js:
- (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
- (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/inspector.html:
- * inspector/front-end/inspector.js:
-
-2011-07-27 Shinya Kawanaka <shinyak@google.com>
-
- Uses isHTMLSpace to normalize white spaces.
- https://bugs.webkit.org/show_bug.cgi?id=57746
-
- Reviewed by Kent Tamura.
-
- Test: fast/forms/option-strip-unicode-spaces.html
-
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::normalizeText):
- Uses isHTMLSpace to trim and replace white spaces.
-
-2011-05-15 Holger Hans Peter Freyther <holger@moiji-mobile.com>
-
- [chromium] Remove include of skia/ext/platform_canvas.h
- https://bugs.webkit.org/show_bug.cgi?id=60852
-
- Reviewed by Hajime Morita.
-
- In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
- skia::PlatformCanvas was eliminated in favor of directly using
- SkCanvas directly. The include of platform_canvas.h was not removed
- leaving the dependency on Chromium in the header files. Remove
- that dependency now.
-
- * platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h
-
-2011-07-27 Mikhail Naganov <mnaganov@chromium.org>
-
- Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
- https://bugs.webkit.org/show_bug.cgi?id=65213
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/DetailedHeapshotView.js:
- (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
-
-2011-07-27 Shinya Kawanaka <shinyak@google.com>
-
- Knob of a disabled or readonly range control should not be draggable.
- https://bugs.webkit.org/show_bug.cgi?id=54820
-
- Reviewed by Kent Tamura.
-
- Made disabled or readonly range control undraggable.
-
- Test: fast/forms/range-drag.html
-
- * html/RangeInputType.cpp:
- (WebCore::RangeInputType::handleMouseDownEvent):
- Added check that the element is readonly or disabled.
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::SliderThumbElement::defaultEventHandler): ditto.
-
-2011-07-27 Yuta Kitamura <yutak@chromium.org>
-
- WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
- https://bugs.webkit.org/show_bug.cgi?id=65232
-
- Reviewed by Kent Tamura.
-
- Add [NoStaticTables] attribute to CloseEvent interface definition. This attribute
- makes the code generator obtain the attributes table used for building ClassInfo
- through JSGlobalData, instead of directly using a statically-allocated table.
-
- Generally speaking, NoStaticTables needs to be specified in interfaces which
- may be accessed from workers.
-
- Tests: http/tests/websocket/tests/hybi/workers/shared-worker-simple.html (updated)
- http/tests/websocket/tests/hybi/workers/worker-simple.html (updated)
-
- * websockets/CloseEvent.idl: Fixed the formatting, too.
-
-2011-07-26 James Robinson <jamesr@chromium.org>
-
- [chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
- https://bugs.webkit.org/show_bug.cgi?id=65224
-
- Reviewed by Kenneth Russell.
-
- There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
- page and kill the GPU process.
-
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerChromium::cleanupResources):
- * platform/graphics/chromium/ContentLayerChromium.h:
-
-2011-07-26 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r91805.
- http://trac.webkit.org/changeset/91805
- https://bugs.webkit.org/show_bug.cgi?id=65226
-
- Breaks @ symbols and changes other font rendering on Windows
- (Requested by enne on #webkit).
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
- (WebCore::drawGlyphsWin):
- (WebCore::Font::drawComplexText):
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::UniscribeHelper::draw):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
- * platform/graphics/skia/PlatformContextSkia.h:
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::windowsCanHandleDrawTextShadow):
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::windowsCanHandleTextDrawingWithoutShadow):
- * platform/graphics/skia/SkiaFontWin.h:
-
-2011-07-26 Adrienne Walker <enne@google.com>
-
- Unreviewed, rolling out r91812.
- http://trac.webkit.org/changeset/91812
- https://bugs.webkit.org/show_bug.cgi?id=65210
-
- Breaks OSX GPU tests.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawLayers):
-
-2011-07-26 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r91809.
- http://trac.webkit.org/changeset/91809
- https://bugs.webkit.org/show_bug.cgi?id=65225
-
- Does not build on Chromium Windows (Requested by abarth on
- #webkit).
-
- * dom/WheelEvent.cpp:
- (WebCore::WheelEvent::WheelEvent):
- (WebCore::WheelEvent::initWheelEvent):
- * dom/WheelEvent.h:
- * page/EventHandler.cpp:
- (WebCore::EventHandler::EventHandler):
- (WebCore::EventHandler::handleGestureEvent):
- (WebCore::EventHandler::handleTouchEvent):
- (WebCore::EventHandler::resetGestureRecognizer):
- * page/EventHandler.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::reset):
- * platform/PlatformGestureEvent.h:
- * platform/PlatformGestureRecognizer.h:
- * platform/chromium/FramelessScrollView.h:
- * platform/chromium/GestureRecognizerChromium.cpp:
- (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
- (WebCore::InnerGestureRecognizer::reset):
- (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
- (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
- (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
- (WebCore::touchDown):
- (WebCore::noGesture):
- (WebCore::click):
- (WebCore::isClickOrScroll):
- (WebCore::inScroll):
- * platform/chromium/GestureRecognizerChromium.h:
- (WebCore::GestureRecognizerChromium::reset):
- (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
- * platform/chromium/PopupMenuChromium.cpp:
- * platform/chromium/PopupMenuChromium.h:
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::handleGestureEvent):
-
-2011-07-26 Dmitry Lomov <dslomov@google.com>
-
- [V8][Chromium] Run workers in a separate v8::Isolate
- https://bugs.webkit.org/show_bug.cgi?id=65004
- This patch allocates a new v8::Isolate for every worker and enters it on worker thread.
-
- Reviewed by David Levin.
-
- Covered by existing chromium tests.
-
- * bindings/v8/DOMDataStore.cpp:
- (WebCore::DOMDataStore::DOMDataStore):
- (WebCore::DOMDataStore::~DOMDataStore):
- * bindings/v8/StaticDOMDataStore.cpp:
- (WebCore::StaticDOMDataStore::StaticDOMDataStore):
- (WebCore::StaticDOMDataStore::~StaticDOMDataStore):
- * bindings/v8/StaticDOMDataStore.h:
- * bindings/v8/V8Binding.h:
- (WebCore::V8BindingPerIsolateData::registerDOMDataStore):
- (WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
- * bindings/v8/V8DOMMap.cpp:
- (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
- (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
- (WebCore::WorkerContextExecutionProxy::initV8):
- * bindings/v8/WorkerContextExecutionProxy.h:
- * bindings/v8/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::WorkerScriptController):
- (WebCore::WorkerScriptController::~WorkerScriptController):
- * bindings/v8/WorkerScriptController.h:
-
-2011-07-26 James Robinson <jamesr@chromium.org>
-
- [chromium] Avoid clearing the framebuffer when compositing in release builds
- https://bugs.webkit.org/show_bug.cgi?id=65210
-
- Reviewed by Kenneth Russell.
-
- We clear the default framebuffer to blue when compositing so it's
- easier to spot regions we miss. This is useful for debugging, but eats
- bandwidth unnecessarily in release builds.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawLayers):
-
-2011-07-26 Jeffrey Pfau <jpfau@apple.com>
-
- New XML tokenizer
- https://bugs.webkit.org/show_bug.cgi?id=64566
-
- Reviewed by Adam Barth.
-
- Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.
-
- * GNUmakefile.list.am:
- * WebCore.gypi:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * xml/parser/NewXMLDocumentParser.cpp:
- (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
- (WebCore::NewXMLDocumentParser::append):
- * xml/parser/NewXMLDocumentParser.h:
- * xml/parser/XMLToken.h:
- * xml/parser/XMLTokenizer.cpp: Added.
- (WebCore::XMLTokenizer::XMLTokenizer):
- (WebCore::::shouldSkipNullCharacters):
- (WebCore::XMLTokenizer::nextToken):
- (WebCore::XMLTokenizer::bufferCharacter):
- (WebCore::XMLTokenizer::parseError):
- * xml/parser/XMLTokenizer.h: Added.
- (WebCore::XMLTokenizer::create):
- (WebCore::XMLTokenizer::gotError):
- (WebCore::XMLTokenizer::shouldSkipNullCharacters):
-
-2011-07-26 Robert Kroeger <rjkroege@chromium.org>
-
- [chromium] Layering violations in gesture recognizer
- https://bugs.webkit.org/show_bug.cgi?id=65044
-
- Reviewed by Adam Barth.
-
- Divided the gesture recognizer up to correct a layering
- violation by moving gesture implementation from it to
- EventHandler::handleGestureEvent so that the gesture recognizer
- could simply be an engine for generating gesture events from
- touch events.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::EventHandler):
- Removed construction of gesture recognizer.
- (WebCore::EventHandler::handleGestureEvent):
- Extended for new gesture events added in this patch.
- (WebCore::EventHandler::handleTouchEvent):
- Removed call into gesture recognizer.
- * page/EventHandler.h:
- * page/FrameView.cpp:
- (WebCore::FrameView::reset):
- Removed code to reset gesture recognizer.
- * platform/PlatformGestureEvent.h:
- (WebCore::PlatformGestureEvent::PlatformGestureEvent):
- (WebCore::PlatformGestureEvent::deltaX):
- (WebCore::PlatformGestureEvent::deltaY):
- (WebCore::PlatformGestureEvent::shiftKey):
- (WebCore::PlatformGestureEvent::ctrlKey):
- (WebCore::PlatformGestureEvent::altKey):
- (WebCore::PlatformGestureEvent::metaKey):
- Added additional gesture types and parameters.
- * platform/PlatformGestureRecognizer.h:
- * platform/chromium/FramelessScrollView.h:
- Added support for displatching gesture and touch events.
- * platform/chromium/GestureRecognizerChromium.cpp:
- (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
- (WebCore::InnerGestureRecognizer::reset):
- (WebCore::InnerGestureRecognizer::constructClickGestureEvent):
- (WebCore::InnerGestureRecognizer::processTouchEventForGestures):
- Removed all depedencies on EventHandler. Instead, create gesture
- events from touch event stream.
- (WebCore::InnerGestureRecognizer::constructScrollGesture):
- (WebCore::touchDown):
- (WebCore::noGesture):
- (WebCore::click):
- (WebCore::isClickOrScroll):
- (WebCore::inScroll):
- (WebCore::GestureRecognizerChromium::processTouchEventForGestures):
- (WebCore::GestureRecognizerChromium::reset):
- * platform/chromium/GestureRecognizerChromium.h:
- * platform/chromium/PopupMenuChromium.cpp:
- Added support to handle touch events and gesture events.
- (WebCore::PopupContainer::handleTouchEvent):
- (WebCore::PopupContainer::handleGestureEvent):
- (WebCore::PopupListBox::handleTouchEvent):
- (WebCore::PopupListBox::handleGestureEvent):
- * platform/chromium/PopupMenuChromium.h:
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::handleGestureEvent):
- Ignores the newly added gesture event types.
-
-2011-07-26 Joseph Pecoraro <joepeck@webkit.org>
-
- Restore Composited Layers Faster from PageCache
- https://bugs.webkit.org/show_bug.cgi?id=65216
-
- Reviewed by Simon Fraser.
-
- Restore the layer tree hierarchy a little sooner, when
- restoring from the page cache. This more closely matches
- original restore behavior.
-
- Existing test showed no change.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::restoreBackingStores):
-
-2011-07-26 Mike Reed <reed@google.com>
-
- [skia] never draw with GDI, so that all text can be gpu-accelerated
- https://bugs.webkit.org/show_bug.cgi?id=65203
-
- Reviewed by Kenneth Russell.
-
- No new tests. existing tests apply to the new drawing path
-
- * platform/graphics/chromium/FontChromiumWin.cpp:
- (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::windowsCanHandleDrawTextShadow):
- (WebCore::windowsCanHandleTextDrawing):
- (WebCore::windowsCanHandleTextDrawingWithoutShadow):
-
-2011-07-26 Kenneth Russell <kbr@google.com>
-
- Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
- https://bugs.webkit.org/show_bug.cgi?id=57042
-
- Reviewed by James Robinson.
-
- * bindings/js/JSArrayBufferViewHelper.h:
- (WebCore::constructArrayBufferViewWithArrayBufferArgument):
- * bindings/v8/custom/V8ArrayBufferViewCustom.h:
- (WebCore::constructWebGLArrayWithArrayBufferArgument):
-
-2011-07-26 Chris Rogers <crogers@google.com>
-
- V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
- https://bugs.webkit.org/show_bug.cgi?id=65222
-
- Reviewed by James Robinson.
-
- No new tests - this fixes upcoming audionode.html layout test
-
- * bindings/v8/custom/V8AudioNodeCustom.cpp:
- (WebCore::V8AudioNode::connectCallback):
-
-2011-07-26 Chris Rogers <crogers@google.com>
-
- AudioContext is not correctly accounting for hardware resources
- https://bugs.webkit.org/show_bug.cgi?id=65217
-
- Reviewed by Kenneth Russell.
-
- No new tests since audio API is not yet implemented.
-
- * webaudio/AudioContext.cpp:
- (WebCore::AudioContext::create):
- (WebCore::AudioContext::AudioContext):
- (WebCore::AudioContext::lazyInitialize):
-
-2011-07-26 Luke Macpherson <macpherson@chromium.org>
-
- Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
- https://bugs.webkit.org/show_bug.cgi?id=65164
-
- Reviewed by Dimitri Glazkov.
-
- No new tests / refactoring only.
-
- * css/CSSPrimitiveValueMappings.h:
- Add casts to/from various numeric types.
- (WebCore::CSSPrimitiveValue::operator short):
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator unsigned short):
- (WebCore::CSSPrimitiveValue::operator int):
- (WebCore::CSSPrimitiveValue::operator float):
- * css/CSSStyleApplyProperty.cpp:
- Add class to handle properties that set an "auto" boolean on RenderStyle.
- (WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
- (WebCore::ApplyPropertyAuto::applyInheritValue):
- (WebCore::ApplyPropertyAuto::applyInitialValue):
- (WebCore::ApplyPropertyAuto::applyValue):
- (WebCore::ApplyPropertyAuto::hasAuto):
- (WebCore::ApplyPropertyAuto::setAuto):
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- * css/CSSStyleSelector.cpp:
- Remove existing implementations.
- (WebCore::CSSStyleSelector::applyProperty):
-
-2011-07-26 Pratik Solanki <psolanki@apple.com>
-
- Add protection space authentication callback code to CFNetwork loader on Mac
- https://bugs.webkit.org/show_bug.cgi?id=65190
- <rdar://problem/9842424>
-
- Reviewed by Oliver Hunt.
-
- Port over protection space authentication callback code from ResourceHandleMac.mm to
- ResourceHandleCFNet.cpp.
-
- * platform/network/ResourceHandle.h:
- * platform/network/cf/ResourceHandleCFNet.cpp:
- (WebCore::canRespondToProtectionSpace):
- (WebCore::ResourceHandle::createCFURLConnection):
- (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
- (WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):
- * platform/network/mac/ResourceHandleMac.mm:
- (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.
-
-2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
-
- Add support for download='filename' attribute in anchors.
- https://bugs.webkit.org/show_bug.cgi?id=64580
-
- Reviewed by Adam Barth.
-
- The download attribute allows the author of the hyperlink to cause the
- browser to download the linked URL. The author can also supply a
- suggested file name in the attribute value. This feature is a recent
- addition to HTML to better support offline applications that use blob
- URLs. Traditionally, web sites use the HTTP Content-Disposition header
- to trigger downloads, but that option isn't available when working
- offline.
-
- There is some question about whether we should initiate a download when
- we receive a DOM-created click event. This patch does initiate the
- download, but we might revise that decision in the future as part of a
- larger change in how WebKit treats the interaction between default
- event handlers and DOM-created events.
-
- Tests: fast/dom/HTMLAnchorElement/anchor-download.html
- fast/dom/HTMLAnchorElement/anchor-nodownload.html
- fast/dom/HTMLAnchorElement/anchor-download-unset.html
- fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::defaultEventHandler):
- (WebCore::HTMLAnchorElement::handleClick):
- * html/HTMLAnchorElement.h:
- * html/HTMLAnchorElement.idl:
- * html/HTMLAttributeNames.in:
- * loader/EmptyClients.h:
- (WebCore::EmptyFrameLoaderClient::startDownload):
- * loader/FrameLoaderClient.h:
-
-2011-07-26 Mark Hahnenberg <mhahnenberg@apple.com>
-
- Refactor automatically generated JS DOM bindings to replace operator new with static create methods
- https://bugs.webkit.org/show_bug.cgi?id=64732
-
- Reviewed by Oliver Hunt.
-
- No new tests.
-
- Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
- with static create methods. This is part of a larger refactoring effort to use static create methods
- in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.
-
- * bindings/js/JSAudioConstructor.h:
- (WebCore::JSAudioConstructor::create):
- * bindings/js/JSDOMBinding.h:
- (WebCore::createWrapper):
- * bindings/js/JSDOMGlobalObject.h:
- (WebCore::getDOMConstructor):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::history):
- (WebCore::JSDOMWindow::location):
- * bindings/js/JSDOMWindowShell.cpp:
- (WebCore::JSDOMWindowShell::setWindow):
- * bindings/js/JSDocumentCustom.cpp:
- (WebCore::JSDocument::location):
- * bindings/js/JSImageConstructor.h:
- (WebCore::JSImageConstructor::create):
- * bindings/js/JSImageDataCustom.cpp:
- (WebCore::toJS):
- * bindings/js/JSOptionConstructor.h:
- (WebCore::JSOptionConstructor::create):
- * bindings/js/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::initScript):
- * bindings/scripts/CodeGeneratorJS.pm:
- (AddIncludesForTypeInImpl):
- (AddIncludesForTypeInHeader):
- (AddIncludesForType):
- (GenerateHeader):
- (GenerateImplementation):
- (GenerateCallbackImplementation):
- (GenerateConstructorDeclaration):
- * bindings/scripts/test/JS/JSTestInterface.cpp:
- (WebCore::JSTestInterfaceConstructor::create):
- (WebCore::JSTestInterface::createPrototype):
- * bindings/scripts/test/JS/JSTestInterface.h:
- (WebCore::JSTestInterface::create):
- (WebCore::JSTestInterfacePrototype::create):
- * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- (WebCore::JSTestMediaQueryListListenerConstructor::create):
- (WebCore::JSTestMediaQueryListListener::createPrototype):
- * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- (WebCore::JSTestMediaQueryListListener::create):
- (WebCore::JSTestMediaQueryListListenerPrototype::create):
- * bindings/scripts/test/JS/JSTestObj.cpp:
- (WebCore::JSTestObjConstructor::create):
- (WebCore::JSTestObj::createPrototype):
- * bindings/scripts/test/JS/JSTestObj.h:
- (WebCore::JSTestObj::create):
- (WebCore::JSTestObjPrototype::create):
- * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- (WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
- (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
- * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- (WebCore::JSTestSerializedScriptValueInterface::create):
- (WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
- * bridge/jni/jsc/JavaArrayJSC.cpp:
- (JavaArray::convertJObjectToArray):
- * bridge/jsc/BridgeJSC.cpp:
- (JSC::Bindings::Instance::newRuntimeObject):
- * bridge/objc/objc_utility.mm:
- (JSC::Bindings::convertObjcValueToValue):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
- * bridge/runtime_array.h:
- (JSC::RuntimeArray::create):
- * bridge/runtime_object.h:
- (JSC::Bindings::RuntimeObject::create):
-
-2011-07-26 Xiaomei Ji <xji@chromium.org>
-
- --webkit-visual-word does not work in multi-line
- https://bugs.webkit.org/show_bug.cgi?id=61344
-
- Reviewed by Ryosuke Niwa.
-
- Replace Position(node, offset, PositionIsOffsetInAnchor) with
- createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position
- before/after <br/> etc. editingIgnoresContent node.
-
- When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns
- InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns
- InlineBox across multiple lines).
-
- * editing/htmlediting.cpp:
- (WebCore::createPositionAvoidingIgnoredNode):
- * editing/htmlediting.h:
- * editing/visible_units.cpp:
- (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
- createPositionAvoidingIgnoredNode().
- (WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
- (WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
- (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
- (WebCore::blockWithPreviousLineBox): Added.
- (WebCore::previousRootInlineBox): Added.
- (WebCore::blockWithNextLineBox): Added.
- (WebCore::nextRootInlineBox): Added.
- (WebCore::leftInlineBox): Added.
- (WebCore::rightInlineBox): Added.
- (WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
- and rightInlineBox().
- (WebCore::rightWordBoundary): Ditto.
- (WebCore::leftWordPositionAcrossBoundary): Ditto.
- (WebCore::rightWordPositionAcrossBoundary): Ditto.
-
-2011-07-26 David Hyatt <hyatt@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=60778
-
- Use after free because of line box culling optimization regression.
-
- In the case of a child with no line box being removed (typically
- a <br> in quirks mode), if there is no previous sibling with a line
- box, then we have a potential problem with the culling optimization.
-
- The culled inline may still have other leaf line box children, but
- they may follow the removed <br>. In this case we can't rely on
- them, since we need a line box that comes before the <br>.
-
- The fix is to simply recur up to the parent if we are a culled inline
- and could not find a previous line box.
-
- Reviewed by Dan Bernstein.
-
- Added editing/execCommand/crash-line-break-after-outdent.html
-
- * rendering/RenderLineBoxList.cpp:
- (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
-
-2011-07-26 Dan Bernstein <mitz@apple.com>
-
- <rdar://problem/9842889> Add a generic pictograph font family
- https://bugs.webkit.org/show_bug.cgi?id=65197
-
- Reviewed by Anders Carlsson.
-
- Test: fast/css/font-family-pictograph.html
-
- * WebCore.exp.in: Export Settings::setPictographFontFamily().
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::identifierForFamily): Added -webkit-pictograph.
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::addFontFaceRule): Ditto.
- (WebCore::fontDataForGenericFamily): Ditto.
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty): Ditto.
- * css/CSSValueKeywords.in:
- * inspector/front-end/CSSKeywordCompletions.js: Ditto.
- * inspector/front-end/SourceCSSTokenizer.js: Ditto.
- (WebInspector.SourceCSSTokenizer):
- * inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
- * page/Settings.cpp:
- (WebCore::Settings::pictographFontFamily): Added this getter.
- (WebCore::Settings::setPictographFontFamily): Added this setter.
- * page/Settings.h:
- * platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.
-
-2011-07-26 Viet-Trung Luu <viettrungluu@chromium.org>
-
- Improve (i.e., speed up) .gyp(i) files for Chromium
- https://bugs.webkit.org/show_bug.cgi?id=65032
-
- Reviewed by Adam Barth.
-
- This re-applies r91595 with the source exclusion fixed.
-
- Test by building (in all supported configurations).
-
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gypi:
-
-2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
-
- [Qt] Disable video support on linux if the dependencies are not found.
-
- If we can't find the necessary dependencies to build the GStreamer media player
- we disable the video support. This is related to http://trac.webkit.org/changeset/91752.
-
- Reviewed by Holger Freyther.
-
- No new tests, it's a build fix.
-
- * features.pri:
-
-2011-07-26 Evan Martin <evan@chromium.org>
-
- regression: generating CSSValueKeywords should not print by default
- https://bugs.webkit.org/show_bug.cgi?id=65195
-
- Reviewed by Tony Chang.
-
- Some refactoring made some callers no longer pass the final 'beQuiet'
- parameter to applyPreprocessor. This flag was only used to print the
- input filename anyway, so remove the flag and just make the caller
- print the filename if it wants this.
-
- * bindings/scripts/IDLParser.pm:
- (Parse): print before calling applyPreprocessor, if necessary.
- * bindings/scripts/preprocessor.pm:
- (applyPreprocessor): remove the beQuiet flag; just always be quiet.
-
-2011-07-26 Raphael Kubo da Costa <kubo@profusion.mobi>
-
- [EFL] Do not crash on the isSlider() assert.
- https://bugs.webkit.org/show_bug.cgi?id=65191
-
- Reviewed by Antonio Gomes.
-
- RenderThemeEfl's paintSliderThumb() just forwarded the call to
- paintSliderTrack(), which, on its turn, called code that assumed that
- object->isSlider() was true. That does not seem to be the case for
- slidethumbs, so any page with an <input type="range"> tag would crash
- WebKit.
-
- We now do what RenderThemeQt does, and assume everything was properly
- done in the call to paintSliderTrack().
-
- No new tests, as this has been uncovered by an existing test.
-
- * platform/efl/RenderThemeEfl.cpp:
- (WebCore::RenderThemeEfl::paintSliderThumb):
-
-2011-07-26 Brian Salomon <bsalomon@google.com>
-
- [SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
- https://bugs.webkit.org/show_bug.cgi?id=65182
-
- Reviewed by Stephen White.
-
- No new tests. Not sure how to test wrong-ctx bugs in layout tests.
-
- * platform/graphics/skia/SkiaFontWin.cpp:
- (WebCore::paintSkiaText):
-
-2011-07-26 Emil A Eklund <eae@chromium.org>
-
- RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code
- https://bugs.webkit.org/show_bug.cgi?id=62478
-
- Reviewed by Simon Fraser.
-
- Test: fast/dom/Range/getClientRects.html
-
- * platform/graphics/FloatRect.h:
- (WebCore::FloatRect::isZero):
- Add izZero method, unlike isEmpty this checks if both the width and the
- height are zero.
-
- * rendering/RenderText.cpp:
- (WebCore::absoluteQuadForTextBox):
- (WebCore::RenderText::absoluteRectsForRange):
- (WebCore::RenderText::absoluteQuadsForRange):
- Break duplicate code out of absoluteRectsForRange and
- absoluteQuadsForRange into shared static function.
-
- Fix what I presume to be a bug in the absoluteQuadsForRange where the
- logicalHeight was always used to set the size in absoluteQuadForTextBox
- as oppsued to the absoluteRectsForRange implementation that uses the
- logicalWidth or the logicalHeight depending on whether it's horizontal or
- vertical.
-
-2011-07-26 Alexandru Chiculita <achicu@adobe.com>
-
- [CSSRegions] Collect flowed elements in different render element
- https://bugs.webkit.org/show_bug.cgi?id=64516
-
- All the RenderObjects that have a specified "flow" name are moved out of the
- normal flow. A RenderFlowThread will collect all such RenderObjects. There is
- a RenderFlowThread for each flow name. The new RenderFlowThread is an anonymous
- RenderBlock that is positioned absolute and will not render directly. In a
- different bug/patch we will add RenderRegion that will take care of rendering the
- RenderFlowThread on screen.
-
- Reviewed by Simon Fraser.
-
- Tests: fast/regions/webkit-flow-renderer-layer.html
- fast/regions/webkit-flow-renderer-nested.html
- fast/regions/webkit-flow-renderer.html
-
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Node.cpp:
- (WebCore::Node::diff):
- * dom/NodeRenderingContext.cpp:
- (WebCore::NodeRenderingContext::NodeRenderingContext):
- (WebCore::NodeRenderingContext::setStyle):
- (WebCore::NodeRenderingContext::nextRenderer):
- (WebCore::NodeRenderingContext::previousRenderer):
- (WebCore::NodeRenderingContext::parentRenderer):
- (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- (WebCore::NodeRendererFactory::createRendererIfNeeded):
- * dom/NodeRenderingContext.h:
- (WebCore::NodeRenderingContext::hasFlowThreadParent):
- (WebCore::NodeRenderingContext::parentFlowRenderer):
- * rendering/RenderFlowThread.cpp: Added.
- (WebCore::RenderFlowThread::RenderFlowThread):
- (WebCore::RenderFlowThread::createFlowThreadStyle):
- (WebCore::RenderFlowThread::nextRendererForNode):
- (WebCore::RenderFlowThread::previousRendererForNode):
- (WebCore::RenderFlowThread::addChild):
- (WebCore::RenderFlowThread::removeChild):
- * rendering/RenderFlowThread.h: Added.
- (WebCore::toRenderFlowThread):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::collectLayers):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isRenderFlowThread):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::RenderTreeAsText::writeRenderObject):
- (WebCore::writeLayers):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::renderFlowThreadWithName):
- * rendering/RenderView.h:
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
-
-2011-07-26 Patrick Dubroy <dubroy@chromium.org>
-
- Filename text in file upload controls is not aligned with button text on
- chromium-linux, chromium-win, and gtk.
-
- https://bugs.webkit.org/show_bug.cgi?id=64692
-
- The fix is to not include the margin, border, and padding in the calculation,
- because those are already accounted for by RenderBlock::baselinePosition().
-
- Reviewed by Dimitri Glazkov.
-
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::paintObject):
-
-2011-07-26 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r91746.
- http://trac.webkit.org/changeset/91746
- https://bugs.webkit.org/show_bug.cgi?id=65180
-
- It broke SL build (Requested by Ossy on #webkit).
-
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::normalizeText):
-
-2011-07-26 Pavel Feldman <pfeldman@google.com>
-
- Web Inspector: Better represent custom getters in the properties pane
- https://bugs.webkit.org/show_bug.cgi?id=16734
-
- Reviewed by Yury Semikhatsky.
-
- Test: inspector/runtime/runtime-getProperties.html
-
- * inspector/InjectedScriptSource.js:
- (.):
- * inspector/Inspector.json:
- * inspector/front-end/ObjectPropertiesSection.js:
- (WebInspector.ObjectPropertyTreeElement.prototype.update):
-
-2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
-
- Reviewed by Andreas Kling.
-
- [Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
- https://bugs.webkit.org/show_bug.cgi?id=63472
-
- Enable the GStreamer backend and the QuickTime backend as default media players
- for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
- can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.
-
- No new tests. The media layout tests are disabled on the Qt port but hopefully with this
- switch we can enable them again.
-
- * WebCore.pri:
- * WebCore.pro:
- * features.pri:
-
-2011-07-26 Pavel Feldman <pfeldman@google.com>
-
- Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn
- https://bugs.webkit.org/show_bug.cgi?id=65112
-
- Reviewed by Yury Semikhatsky.
-
- Test: inspector/runtime/runtime-setPropertyValue.html
-
- * inspector/InjectedScript.cpp:
- * inspector/InjectedScript.h:
- * inspector/InjectedScriptSource.js:
- (.):
- * inspector/Inspector.json:
- * inspector/InspectorRuntimeAgent.cpp:
- * inspector/InspectorRuntimeAgent.h:
- * inspector/front-end/RemoteObject.js:
- (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
- (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
- (WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
- (WebInspector.RemoteObject.prototype.setPropertyValue):
-
-2011-07-26 Pavel Feldman <pfeldman@google.com>
-
- Re-applying r91665 and r91668 with JSC issues fixed.
-
- Web Inspector: use dedicated type for object id in the protocol.
- Web Inspector: refactor remote object structure to contain value for primitive values.
-
- https://bugs.webkit.org/show_bug.cgi?id=65103
- https://bugs.webkit.org/show_bug.cgi?id=65110
-
- Reviewed by Yury Semikhatsky.
-
- * inspector/InjectedScript.cpp:
- (WebCore::InjectedScript::callFunctionOn):
- * inspector/InjectedScript.h:
- * inspector/InjectedScriptSource.js:
- * inspector/Inspector.json:
- * inspector/InspectorRuntimeAgent.cpp:
- (WebCore::InspectorRuntimeAgent::callFunctionOn):
- * inspector/InspectorValues.cpp:
- (WebCore::InspectorBasicValue::writeJSON):
- * inspector/front-end/ConsoleView.js:
- (WebInspector.ConsoleView.prototype._format):
- (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
- (WebInspector.ConsoleMessage.prototype._format):
- * inspector/front-end/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
- * inspector/front-end/ObjectPropertiesSection.js:
- (WebInspector.ObjectPropertyTreeElement.prototype.update):
- * inspector/front-end/PropertiesSidebarPane.js:
- (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
- * inspector/front-end/RemoteObject.js:
- (WebInspector.RemoteObject):
- (WebInspector.RemoteObject.fromPrimitiveValue):
- (WebInspector.RemoteObject.fromPayload):
- (WebInspector.RemoteObject.prototype.get subtype):
- (WebInspector.RemoteObject.prototype.callFunction):
- (WebInspector.LocalJSONObject.prototype.get description):
- (WebInspector.LocalJSONObject.prototype.get type):
- (WebInspector.LocalJSONObject.prototype.get subtype):
- * inspector/front-end/SourceFrame.js:
- (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
- (WebInspector.SourceFrame.prototype._showPopup):
- * inspector/front-end/inspector.js:
- (WebInspector.log.logMessage):
- (WebInspector.log):
- (WebInspector.inspect):
-
-2011-07-26 Nikolas Zimmermann <nzimmermann@rim.com>
-
- Prepare animVal support - phase 2
- https://bugs.webkit.org/show_bug.cgi?id=65167
-
- Reviewed by Dirk Schulze.
-
- Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
- will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.
-
- Doesn't affect any tests, yet.
-
- * svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added).
- (WebCore::SVGPathElement::svgAttributeChanged):
- * svg/SVGPathSegWithContext.h: Ditto.
- (WebCore::SVGPathSegWithContext::animatedProperty):
- * svg/SVGPolyElement.cpp: Ditto.
- (WebCore::SVGPolyElement::parseMappedAttribute):
- * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type.
- (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
- * svg/properties/SVGAnimatedListPropertyTearOff.h:
- (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not.
- (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
- * svg/properties/SVGAnimatedProperty.h:
- (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS.
- (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper.
- (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
- * svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
- * svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff.
- (WebCore::SVGAnimatedPropertyTearOff::isAnimating):
- (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
- (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal):
- (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
- * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
- (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating):
- (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
- * svg/properties/SVGPropertyTearOff.h:
- (WebCore::SVGPropertyTearOff::updateAnimVal):
-
-2011-07-26 Shinya Kawanaka <shinyak@google.com>
-
- Uses isHTMLSpace to normalize white spaces.
- https://bugs.webkit.org/show_bug.cgi?id=57746
-
- Reviewed by Kent Tamura.
-
- Test: fast/forms/option-strip-unicode-spaces.html
-
- * dom/OptionElement.cpp:
- (WebCore::OptionElement::normalizeText):
- Uses isHTMLSpace to trim and replace white spaces.
-
-2011-07-25 Ryuan Choi <ryuan.choi@samsung.com>
-
- [CMAKE] Split JSC related files from WebCore/CMakeLists.txt
- https://bugs.webkit.org/show_bug.cgi?id=61350
-
- Reviewed by Daniel Bates.
-
- No new tests, just moving jsc related files from CMakeLists.txt to UseJSC.cmake.
-
- * CMakeLists.txt:
- * UseJSC.cmake:
-
-2011-07-25 Dan Bernstein <mitz@apple.com>
-
- Fix the build by committing a rename in this file that I neglected to include in the previous commit.
-
- * css/CSSFontFaceSource.h:
-
-2011-07-25 Dan Bernstein <mitz@apple.com>
-
- <rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
- https://bugs.webkit.org/show_bug.cgi?id=65123
-
- Reviewed by Anders Carlsson and Darin Adler.
-
- Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
- code from under it, and instead defer that work using a zero-delay timer.
-
- * css/CSSFontFaceSource.cpp:
- (WebCore::CSSFontFaceSource::CSSFontFaceSource):
- (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
- (WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
- a zero-delay timer to do it.
- (WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.
- * css/CSSFontFaceSource.h:
-
-2011-07-25 Al Patrick <apatrick@chromium.org>
-
- Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
- Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
- https://bugs.webkit.org/show_bug.cgi?id=65043
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
- (WebCore::Canvas2DLayerChromium::updateCompositorResources):
- * platform/graphics/chromium/DrawingBufferChromium.cpp:
- (WebCore::DrawingBuffer::publishToPlatformLayer):
- * platform/graphics/chromium/Extensions3DChromium.h:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::LayerRendererChromium):
- (WebCore::LayerRendererChromium::drawLayers):
- (WebCore::LayerRendererChromium::addChildContext):
- (WebCore::LayerRendererChromium::removeChildContext):
- * platform/graphics/chromium/LayerRendererChromium.h:
-
-2011-07-25 Sam Weinig <sam@webkit.org>
-
- Refactor ScrollableArea pinned predicates to be more generally useful
- <rdar://problem/9740379>
-
- Reviewed by Dan Bernstein.
-
- * platform/ScrollableArea.cpp:
- (WebCore::ScrollableArea::isPinnedInBothDirections):
- (WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
- (WebCore::ScrollableArea::isPinnedVerticallyInDirection):
- * platform/ScrollableArea.h:
-
-2011-07-25 Nico Weber <thakis@chromium.org>
-
- [chromium] components/mac: Make webcore not depend on CoreAnimation
- https://bugs.webkit.org/show_bug.cgi?id=65143
-
- Reviewed by James Robinson.
-
- * platform/chromium/ScrollAnimatorChromiumMac.mm:
-
-2011-07-25 Ian Henderson <ianh@apple.com>
-
- WebFrame should have a method to determine its visual emptiness
- https://bugs.webkit.org/show_bug.cgi?id=64223
-
- Reviewed by Dan Bernstein.
-
- * page/FrameView.h:
- (WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
- so we can tell whether it's visually non-empty.
-
2011-07-25 Scott Graham <scottmg@chromium.org>
REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
« no previous file with comments | « no previous file | Source/WebCore/loader/cache/CachedResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698