Issue 7542016: Fix to bug 91320.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7542016: Fix to bug 91320. (Closed)

Created:
9 years, 4 months ago by abeera

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Nico, Scott Byer

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix to bug 91320. Function prototype in Cloud Print Virtual Driver changed to void. Gyp file updated. BUG=91320 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95516

Patch Set 2 : Remove unused variable. #

Patch Set 3 : Fixed GYP files. #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	cloud_print/virtual_driver/posix/backend.gyp	View	1 2	1 chunk	+3 lines, -0 lines	2 comments	Download
	M	cloud_print/virtual_driver/posix/virtual_driver_posix.cc	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/7542016/diff/4001/cloud_print/virtual_driver/posix/backend.gyp File cloud_print/virtual_driver/posix/backend.gyp (right): http://codereview.chromium.org/7542016/diff/4001/cloud_print/virtual_driver/posix/backend.gyp#newcode10 cloud_print/virtual_driver/posix/backend.gyp:10: 'variables': { 'variables' is toplevel, not part of 'target_defaults'. ...

9 years, 4 months ago (2011-08-04 22:29:04 UTC) #3

abeera

9 years, 4 months ago (2011-08-04 22:41:36 UTC) #4

http://codereview.chromium.org/7542016/diff/4001/cloud_print/virtual_driver/p...
File cloud_print/virtual_driver/posix/backend.gyp (right):

http://codereview.chromium.org/7542016/diff/4001/cloud_print/virtual_driver/p...
cloud_print/virtual_driver/posix/backend.gyp:10: 'variables': {
Setting variables like this threw the compile errors that were reported in the
bug. (I copied from
cloud_print/virtual_driver/win/install/virtual_driver_install.gyp). Also, this 
file will be updated once I land my Mac virtual driver CL. Should I fix it
anyways? Thanks,
Abeer
On 2011/08/04 22:29:04, Nico wrote:
> 'variables' is toplevel, not part of 'target_defaults'. see chrome/chrome.gyp
> for an example

Done.