Issue 7541080: Enable /PROFILE for Release builds and remove it from Debug builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541080: Enable /PROFILE for Release builds and remove it from Debug builds. (Closed)

Created:
9 years, 4 months ago by Roger McFarlane (Google)

Modified:
9 years ago

Reviewers:
Jeff Bailey (chromium), commit-bot: I haz the power, M-A Ruel, Sigurður Ásgeirsson

CC:
chromium-reviews, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enable /PROFILE for Release builds and remove it from Debug builds.

Patch Set 2 : fixed a small typo in a comment #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+9 lines, -0 lines	1 comment	Download
	M	chrome/chrome_dll.gypi	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/7541080/diff/2001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7541080/diff/2001/build/common.gypi#newcode1157 build/common.gypi:1157: # LinkIncremental is a tri-state boolean, where 0 ...

9 years, 4 months ago (2011-08-08 15:21:17 UTC) #2

Sigurður Ásgeirsson

On 2011/08/08 15:26:31, Ruðrugis wrote: > lgtm Committed as http://crrev.com/7541080.

9 years, 4 months ago (2011-08-08 21:02:32 UTC) #4

Sigurður Ásgeirsson

On 2011/08/08 21:02:32, Ruðrugis wrote: > On 2011/08/08 15:26:31, Ruðrugis wrote: > > lgtm > ...

9 years, 4 months ago (2011-08-08 21:03:24 UTC) #5

commit-bot: I haz the power

9 years, 4 months ago (2011-08-08 22:57:36 UTC) #6

Can't apply patch for file build/common.gypi.
While running patch -p0 --forward --force;
patching file build/common.gypi
Hunk #1 FAILED at 1154.
1 out of 1 hunk FAILED -- saving rejects to file build/common.gypi.rej

Expand Messages | Collapse Messages

Issue 7541080: Enable /PROFILE for Release builds and remove it from Debug builds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed a small typo in a comment #

Messages