Issue 7541078: Remove orphaned file src/shell.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541078: Remove orphaned file src/shell.h (Closed)

Created:
9 years, 4 months ago by Jakob Kummerow

Modified:
9 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove orphaned file src/shell.h This has nothing to do with the sample shell. Committed: http://code.google.com/p/v8/source/detail?r=8857

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -56 lines)			Patch
	D	src/shell.h	View		1 chunk	+0 lines, -55 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. Noticed this file while digging through v8.gyp. AFAICT nothing breaks if we just remove ...

9 years, 4 months ago (2011-08-08 14:18:19 UTC) #1

Yang

9 years, 4 months ago (2011-08-08 14:22:49 UTC) #2

On 2011/08/08 14:18:19, jkummerow wrote:
> PTAL. Noticed this file while digging through v8.gyp. AFAICT nothing breaks if
> we just remove it (none of the SCons build files even mention the file).

LGTM. src/shell.h dates a few weeks earlier than samples/shell.cc, so I think we
are safe to say that it's just the remains of some abandoned version of a shell.

Expand Messages | Collapse Messages