Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 7541074: Fix 2 Dr. Memory issues (Closed)

Created:
9 years, 4 months ago by greggman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix 2 Dr. Memory issues 1) Unit tests were incorrectly using TextureInfo 2) GLES2Implementation::TexSubImageImpl was reading 1-7 bytes too many. TEST=ran with Dr.Memory BUG=91786 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, please review. It's small
9 years, 4 months ago (2011-08-08 09:30:46 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 4 months ago (2011-08-08 15:22:08 UTC) #2
apatrick_chromium
LGTM
9 years, 4 months ago (2011-08-08 19:27:31 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-08 23:25:43 UTC) #4
Change committed as 95906

Powered by Google App Engine
This is Rietveld 408576698