Issue 7541065: autofill: Refactor PersonalDataManager::Observer into its own header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541065: autofill: Refactor PersonalDataManager::Observer into its own header file. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, GeorgeY, ncarter (slow), Raghu Simha, idana, tfarina, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

autofill: Refactor PersonalDataManager::Observer into its own header file. This avoids having a nested class Observer in PersonalDataManager. BUG=None TEST=None R=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95871

Patch Set 1 : #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -38 lines)			Patch
M	chrome/browser/autofill/autofill_ie_toolbar_import_win.cc	View	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.h	View	3 chunks	+4 lines, -15 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
A	chrome/browser/autofill/personal_data_manager_observer.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager_unittest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/autofill_data_type_controller.h	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/autofill_data_type_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/autofill_profile_data_type_controller.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/live_sync/autofill_helper.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/test/live_sync/autofill_helper.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/live_sync/performance/autofill_sync_perf_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/live_sync/two_client_autofill_sync_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages