Issue 7541062: Web Intents: Fix a leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541062: Web Intents: Fix a leak. (Closed)

Created:
9 years, 4 months ago by James Hawkins

Modified:
9 years, 4 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Web Intents: Fix a leak. Delete the query after notifying the consumer. Also clean up a style issue. BUG=91950 TEST=none R=groby@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95842

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	chrome/browser/intents/web_intents_registry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/intents/web_intents_registry.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

On 2011/08/06 17:16:58, James Hawkins wrote: I'd give the green light, but I'm technically not ...

9 years, 4 months ago (2011-08-08 17:14:26 UTC) #2

groby-ooo-7-16

9 years, 4 months ago (2011-08-08 18:18:25 UTC) #3

On 2011/08/08 17:14:26, groby wrote:
> On 2011/08/06 17:16:58, James Hawkins wrote:
> 
> I'd give the green light, but I'm technically not supposed to...
> 
> Also, updated the description - this fixes the bug you just marked as started.
> (Thanks!)

LGTM

Expand Messages | Collapse Messages