Issue 7541061: Fix ARM build bustage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541061: Fix ARM build bustage. (Closed)

Created:
9 years, 4 months ago by darin (slow to review)

Modified:
9 years, 4 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, darin-cc_chromium.org, Ami GONE FROM CHROMIUM

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix ARM build bustage. TBR=vrk@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95729

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/plugins/ppapi/ppb_video_decoder_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vrk (LEFT CHROMIUM)

BTW, the original version of code with the "return NULL"s does cross-compile to ARM successfully ...

9 years, 4 months ago (2011-08-08 18:19:11 UTC) #3

darin (slow to review)

9 years, 4 months ago (2011-08-08 18:29:30 UTC) #4

I have no idea.  Maybe ask on chromium-dev?

On Mon, Aug 8, 2011 at 11:19 AM, <vrk@chromium.org> wrote:

> BTW, the original version of code with the "return NULL"s does
> cross-compile to
> ARM successfully when compiled locally...
>
> Are the builders stricter in promoting warnings to errors? Any idea why
> this
> could be?
>
>
>
http://codereview.chromium.**org/7541061/<http://codereview.chromium.org/7541...
>

Expand Messages | Collapse Messages