Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 7541057: Breakpad: Build an x86-64 version of crash_service.exe on Windows (Closed)

Created:
9 years, 4 months ago by Mark Seaborn
Modified:
9 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Breakpad: Build an x86-64 version of crash_service.exe on Windows This is needed for testing Native Client's support for Breakpad on x86-64. However, ultimately crash_service is only used for testing (Google Update's crash reporter is what is used in an installation of the official Chrome build). Initially, crash_service.exe will only work on x86-32 processes, and crash_service64.exe will only work on x86-64 processes. Eventually we will want to make crash_service64.exe work for both 32-bit and 64-bit processes. It might not be possible to make crash_service.exe work on 64-bit processes because Windows' ReadMemory() function only works on 64-bit target processes if the caller is a 64-bit process. BUG=89730 TEST=NaCl's run_inbrowser_trusted_crash_in_startup_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/chrome.gyp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
9 years, 4 months ago (2011-08-05 23:41:42 UTC) #1
bradn
LGTM
9 years, 4 months ago (2011-08-05 23:53:24 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-06 03:28:07 UTC) #3
Change committed as 95728

Powered by Google App Engine
This is Rietveld 408576698