Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 7541047: CrOS OOBE: Fix OOBE step CSS class updating when jumping. (Closed)

Created:
9 years, 4 months ago by Mattias Nissler (ping if slow)
Modified:
9 years, 4 months ago
Reviewers:
xiyuan, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

CrOS OOBE: Fix OOBE step CSS class updating when jumping. Previously, the code would only change the CSS classes for the current and the next step. This resulted in any steps between these two to incorrectly remain at their old state, which results in the next transition not working. BUG=chromium-os:18736 TEST=Enterprise enrollment screen is actually visible when triggered through accelarator. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95807

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.js View 1 3 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
Please review!
9 years, 4 months ago (2011-08-05 19:36:48 UTC) #1
xiyuan
LGTM Do you want to fix the signin screen name as well? (i.e. add 'gaia-signin' ...
9 years, 4 months ago (2011-08-05 19:51:29 UTC) #2
Mattias Nissler (ping if slow)
On 2011/08/05 19:51:29, xiyuan wrote: > LGTM > > Do you want to fix the ...
9 years, 4 months ago (2011-08-05 20:08:44 UTC) #3
James Hawkins
LGTM
9 years, 4 months ago (2011-08-05 20:17:50 UTC) #4
Mattias Nissler (ping if slow)
9 years, 4 months ago (2011-08-08 11:23:39 UTC) #5
Committing soonish.

http://codereview.chromium.org/7541047/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.js (right):

http://codereview.chromium.org/7541047/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.js:82: * @param {state} state one
of 'left', 'current', 'right'.
On 2011/08/05 19:51:29, xiyuan wrote:
> nit: {string}

Done.

Powered by Google App Engine
This is Rietveld 408576698