Issue 7541043: Revert 95611 - Always call the class methods to save/restore contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541043: Revert 95611 - Always call the class methods to save/restore contexts. (Closed)

Created:
9 years, 4 months ago by yzshen1

Modified:
9 years, 4 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 95611 - Always call the class methods to save/restore contexts. If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current. BUG=90140 TEST=repeatedly select items in an open file dialog in column mode; no crash Review URL: http://codereview.chromium.org/7572031 TBR=avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -108 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_cell.mm	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar/find_bar_view.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_view.mm	View	4 chunks	+75 lines, -79 lines	0 comments	Download
M	chrome/default_plugin/plugin_impl_mac.mm	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/clipboard/clipboard_mac.mm	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h	View	1 chunk	+5 lines, -9 lines	0 comments	Download
M	ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm	View	1 chunk	+7 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)