Update asynchronous CookieMonster API to login_utils.

Update asynchronous CookieMonster API to login_utils.
BUG=68657
TEST=CookieMonsterTest.InitializeFromCookieMonster

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95825

[ycxiao, 2011-08-01 14:38:14]

PTAL.

Thanks,
Yancheng

[zel, 2011-08-03 21:44:04]

http://codereview.chromium.org/7541021/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7541021/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:134: void HasCookie(const
net::CookieList& existing_cookies) {
the code changed here, we don't fetch two cookie lists anymore, please sync and
update your CL

[ycxiao, 2011-08-04 15:16:53]

PTAL.

Thanks!

Yancheng

[zel, 2011-08-04 16:01:07]

http://codereview.chromium.org/7541021/diff/8005/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7541021/diff/8005/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:136: void
InitializeCookieMonster(const net::CookieList& cookies) {
put assert there that shows which thread is expected here

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

[ycxiao, 2011-08-04 17:00:50]

http://codereview.chromium.org/7541021/diff/8005/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7541021/diff/8005/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:136: void
InitializeCookieMonster(const net::CookieList& cookies) {
On 2011/08/04 16:01:07, zel wrote:
> put assert there that shows which thread is expected here
> 
> DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

Done.

[ycxiao, 2011-08-04 22:36:15]

Hi Randy,

Could you take a look at this? 
This is updating the CookeiMonster API to login_utils.cc.

Thanks,

Yancheng

[ycxiao, 2011-08-04 22:38:12]

Hi Zelidrag,

Done with your comment. PTAL.

Thanks,
Yancheng

[Randy Smith (Not in Mondays), 2011-08-05 19:36:37]

LGTM.  I still like the original interface better, but I agree there's no good
way to implement it in the new async world.

[zel, 2011-08-05 19:47:43]

LGTM

fill in TEST=

[commit-bot: I haz the power, 2011-08-06 16:14:39]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for diner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2011-08-07 04:18:41]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 95737, job name
was 7541021-8007 (retry) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-08-08 16:31:09]

Change committed as 95825