Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/version_unittest.cc

Issue 7541015: Add a convenience function to Version (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/version.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version_unittest.cc
===================================================================
--- base/version_unittest.cc (revision 94719)
+++ base/version_unittest.cc (working copy)
@@ -85,5 +85,7 @@
scoped_ptr<Version> rhs(Version::GetVersionFromString(cases[i].rhs));
EXPECT_EQ(lhs->CompareTo(*rhs), cases[i].expected) <<
cases[i].lhs << " ? " << cases[i].rhs;
+
+ EXPECT_EQ(lhs->IsOlderThan(cases[i].rhs), (cases[i].expected == -1));
}
}
« no previous file with comments | « base/version.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698