Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7541015: Add a convenience function to Version (Closed)

Created:
9 years, 4 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Add a convenience function to Version Came up as in item in a component updater review. It is a common pattern used in extension updater and component updater. TEST=included BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94928

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M base/version.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M base/version.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M base/version_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 4 months ago (2011-07-31 22:34:42 UTC) #1
Evan Martin
LGTM
9 years, 4 months ago (2011-07-31 22:42:52 UTC) #2
asargent_no_longer_on_chrome
9 years, 4 months ago (2011-08-01 16:30:44 UTC) #3
LGTM too

Powered by Google App Engine
This is Rietveld 408576698