Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/app/breakpad_win.cc

Issue 7538036: Windows Breakpad: Allow the crash dump dir and pipe name to be overridden (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix to use W version of GetEnvironmentVariable Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/crash_service/crash_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/breakpad_win.cc
diff --git a/chrome/app/breakpad_win.cc b/chrome/app/breakpad_win.cc
index ecc12e5ecc871ff664b25aaf670f117ffc95b573..b85312507a11a980544a752387280d18d2cf9b5c 100644
--- a/chrome/app/breakpad_win.cc
+++ b/chrome/app/breakpad_win.cc
@@ -519,7 +519,15 @@ static DWORD __stdcall InitCrashReporterThread(void* param) {
std::wstring pipe_name;
if (use_crash_service) {
// Crash reporting is done by crash_service.exe.
- pipe_name = kChromePipeName;
+ const wchar_t* var_name = L"CHROME_BREAKPAD_PIPE_NAME";
+ DWORD value_length = ::GetEnvironmentVariableW(var_name, NULL, 0);
+ if (value_length == 0) {
+ pipe_name = kChromePipeName;
+ } else {
+ scoped_array<wchar_t> value(new wchar_t[value_length]);
+ ::GetEnvironmentVariableW(var_name, value.get(), value_length);
+ pipe_name = value.get();
+ }
} else {
// We want to use the Google Update crash reporting. We need to check if the
// user allows it first (in case the administrator didn't already decide
« no previous file with comments | « no previous file | chrome/tools/crash_service/crash_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698