Jumplist Bug

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
===================================================================
--- chrome/browser/ui/views/frame/browser_view.cc	(revision 96768)
+++ chrome/browser/ui/views/frame/browser_view.cc	(working copy)
@@ -353,6 +353,10 @@
   // Stop hung plugin monitoring.
   ticker_.Stop();
   ticker_.UnregisterTickHandler(&hung_window_detector_);
+
+  if (JumpList::Enabled()) {

[MAD, 2011/08/16 17:02:31]

Here, you should rely on jumplist_ not being NULL instead...

And maybe add a comment stating that this must be called before we destroy the
profile used by the jumplist...

+    jumplist_->Terminate();
+  }
 #endif
 
 #if !defined(OS_CHROMEOS)
@@ -2002,7 +2006,7 @@
   // Create a custom JumpList and add it to an observer of TabRestoreService
   // so we can update the custom JumpList when a tab is added or removed.
   if (JumpList::Enabled()) {
-    jumplist_.reset(new JumpList);
+    jumplist_ = new JumpList();
     jumplist_->AddObserver(browser_->profile());
   }