Issue 7538016: Make window.{undefined,NaN,Infinity} read-only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7538016: Make window.{undefined,NaN,Infinity} read-only (Closed)

Created:
9 years, 4 months ago by Jakob Kummerow

Modified:
9 years, 4 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make window.{undefined,NaN,Infinity} read-only as per ES5. BUG=89490 TEST=es5conform 15.1.*, 15.2.3.*; mjsunit/undeletable-functions Committed: http://code.google.com/p/v8/source/detail?r=8766

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -20 lines)			Patch
M	src/runtime.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/es5conform/es5conform.status	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	test/mjsunit/undeletable-functions.js	View	2 chunks	+3 lines, -1 line	1 comment	Download
M	test/sputnik/sputnik.status	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 4 months ago (2011-08-01 10:06:20 UTC) #2

LGTM.

http://codereview.chromium.org/7538016/diff/1/test/mjsunit/undeletable-functi...
File test/mjsunit/undeletable-functions.js (left):

http://codereview.chromium.org/7538016/diff/1/test/mjsunit/undeletable-functi...
test/mjsunit/undeletable-functions.js:192: assertEquals("foo", type[prop],
"overwritable: " + prop);
I don't understand why we expected "foo" before :)

It seems like someone could rewrite this test to use the ES5 reflective methods
(e.g. Object.getOwnPropertyDescriptor).  Presuming we have good test coverage of
that and that we don't otherwise have special handling of these properties, that
would be more direct.

Expand Messages | Collapse Messages