Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also change TestBrowserWindow Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/browser_window_factory.mm ('K') | « chrome/browser/ui/cocoa/browser_window_factory.mm ('k') | chrome/browser/ui/gtk/browser_window_factory_gtk.cc » ('j') | chrome/browser/ui/panels/native_panel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
index b84a84778b6168a4a2dd4c4c8cdc6c6a96b3b789..b44325a79e4eb495f386f591083aad39061ea867 100644
--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
@@ -253,7 +253,8 @@ const float kRightEdgeOffset = 25;
// The browser window might have changed while the FindBar was hidden.
// Update its position now.
- [browserWindowController_ layoutSubviews];
+ if (browserWindowController_)
+ [browserWindowController_ layoutSubviews];
// Move to the correct horizontal position first, to prevent the FindBar
// from jumping around when switching tabs.
« chrome/browser/ui/cocoa/browser_window_factory.mm ('K') | « chrome/browser/ui/cocoa/browser_window_factory.mm ('k') | chrome/browser/ui/gtk/browser_window_factory_gtk.cc » ('j') | chrome/browser/ui/panels/native_panel.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698