Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove underscore. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/ui/bookmarks/bookmark_bar.h" 9 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
10 #include "chrome/common/content_settings_types.h" 10 #include "chrome/common/content_settings_types.h"
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 321
322 // Returns the desired bounds for instant in screen coordinates. Note that if 322 // Returns the desired bounds for instant in screen coordinates. Note that if
323 // instant isn't currently visible this returns the bounds instant would be 323 // instant isn't currently visible this returns the bounds instant would be
324 // placed at. 324 // placed at.
325 virtual gfx::Rect GetInstantBounds() = 0; 325 virtual gfx::Rect GetInstantBounds() = 0;
326 326
327 // Return the correct disposition for a popup window based on |bounds|. 327 // Return the correct disposition for a popup window based on |bounds|.
328 virtual WindowOpenDisposition GetDispositionForPopupBounds( 328 virtual WindowOpenDisposition GetDispositionForPopupBounds(
329 const gfx::Rect& bounds) = 0; 329 const gfx::Rect& bounds) = 0;
330 330
331 // Construct a FindBar implementation for the |browser|.
332 virtual FindBar* CreateFindBar() = 0;
333
331 #if defined(OS_CHROMEOS) 334 #if defined(OS_CHROMEOS)
332 // Shows the keyboard overlay dialog box. 335 // Shows the keyboard overlay dialog box.
333 virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0; 336 virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0;
334 #endif 337 #endif
335 338
336 // Construct a BrowserWindow implementation for the specified |browser|. 339 // Construct a BrowserWindow implementation for the specified |browser|.
337 static BrowserWindow* CreateBrowserWindow(Browser* browser); 340 static BrowserWindow* CreateBrowserWindow(Browser* browser);
338 341
339 // Construct a FindBar implementation for the specified |browser|.
340 static FindBar* CreateFindBar(Browser* browser_window);
341
342 protected: 342 protected:
343 friend class BrowserList; 343 friend class BrowserList;
344 friend class BrowserView; 344 friend class BrowserView;
345 virtual void DestroyBrowser() = 0; 345 virtual void DestroyBrowser() = 0;
346 }; 346 };
347 347
348 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS) 348 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
349 class BookmarkBarView; 349 class BookmarkBarView;
350 class LocationBarView; 350 class LocationBarView;
351 351
(...skipping 21 matching lines...) Expand all
373 373
374 // Returns the ToolbarView. 374 // Returns the ToolbarView.
375 virtual ToolbarView* GetToolbarView() const = 0; 375 virtual ToolbarView* GetToolbarView() const = 0;
376 #endif 376 #endif
377 377
378 protected: 378 protected:
379 virtual ~BrowserWindowTesting() {} 379 virtual ~BrowserWindowTesting() {}
380 }; 380 };
381 381
382 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 382 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698