Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

chrome/browser/ui/cocoa/browser_window_factory.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
-#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
-#include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 
 // Create the controller for the Browser, which handles loading the browser
 // window from the nib. The controller takes ownership of |browser|.
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
   BrowserWindowController* controller =
       [[BrowserWindowController alloc] initWithBrowser:browser];
   return [controller browserWindow];
 }
-
-// static
-FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
-  // We could push the AddFindBar() call into the FindBarBridge
-  // constructor or the FindBarCocoaController init, but that makes
-  // unit testing difficult, since we would also require a
-  // BrowserWindow object.
-  BrowserWindowCocoa* window =
-      static_cast<BrowserWindowCocoa*>(browser->window());

[prasadt, 2011/08/01 18:40:22]

How about doing an IsPanel() check on the browser object and do the right thing?
 I think that'll simplify the check-in quite a bit and won't touch other
platforms.

-  FindBarBridge* bridge = new FindBarBridge();
-  window->AddFindBar(bridge->find_bar_cocoa_controller());
-  return bridge;
-}