Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

chrome/browser/ui/browser_window.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #pragma once
 
 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
 #include "chrome/common/content_settings_types.h"
@@ skipping 310 matching lines @@
 
   // Returns the desired bounds for instant in screen coordinates. Note that if
   // instant isn't currently visible this returns the bounds instant would be
   // placed at.
   virtual gfx::Rect GetInstantBounds() = 0;
 
   // Return the correct disposition for a popup window based on |bounds|.
   virtual WindowOpenDisposition GetDispositionForPopupBounds(
       const gfx::Rect& bounds) = 0;
 
+  // Construct a FindBar implementation for the |browser|.
+  virtual FindBar* CreateFindBar() = 0;

[jianli, 2011/08/01 18:52:13]

It seems that we can add const modifier to this method.

[jennb, 2011/08/08 17:26:02]

As discussed, leaving as-is. I can't guarantee that implementations won't want
to store a pointer or some other change when creating a find bar.

+

[jianli, 2011/08/01 18:52:13]

One extra empty line.

[jennb, 2011/08/08 17:26:02]

Done.

+
 #if defined(OS_CHROMEOS)
   // Shows the keyboard overlay dialog box.
   virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0;
 #endif
 
   // Construct a BrowserWindow implementation for the specified |browser|.
   static BrowserWindow* CreateBrowserWindow(Browser* browser);
 
-  // Construct a FindBar implementation for the specified |browser|.
-  static FindBar* CreateFindBar(Browser* browser_window);
-
  protected:
   friend class BrowserList;
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
 class BookmarkBarView;
 class LocationBarView;
 
@@ skipping 21 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_