Send back the URL that matched the SafeBrowsing list with the CSD ping.

Send back the URL that matched the SafeBrowsing list with the CSD ping.

BUG=91723
TEST=BrowserFeatureExtractorTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95115

[Brian Ryner, 2011-08-01 19:08:11]

Would it make sense to add check that unsafe_resource_ is getting set correctly
in client_side_detection_host_unittest ?

[noelutz, 2011-08-01 23:04:44]

On 2011/08/01 19:08:11, Brian Ryner wrote:
> Would it make sense to add check that unsafe_resource_ is getting set
correctly
> in client_side_detection_host_unittest ?

Done.

[Brian Ryner, 2011-08-01 23:11:30]

LGTM

[mattm, 2011-08-01 23:19:35]

lgtm

http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
(right):

http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc:262:
EXPECT_EQ(resource.client, csd_host_->unsafe_resource_->client);
nit: shouldn't this check it gets NULLed?

[noelutz, 2011-08-01 23:26:44]

On 2011/08/01 23:19:35, mattm wrote:
> lgtm
> 
>
http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
> File chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
> (right):
> 
>
http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
> chrome/browser/safe_browsing/client_side_detection_host_unittest.cc:262:
> EXPECT_EQ(resource.client, csd_host_->unsafe_resource_->client);
> nit: shouldn't this check it gets NULLed?

Please take another look.
noe.

[noelutz, 2011-08-01 23:26:49]

http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
(right):

http://codereview.chromium.org/7538009/diff/3001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/client_side_detection_host_unittest.cc:262:
EXPECT_EQ(resource.client, csd_host_->unsafe_resource_->client);
On 2011/08/01 23:19:35, mattm wrote:
> nit: shouldn't this check it gets NULLed?

good point. done.

[commit-bot: I haz the power, 2011-08-02 18:31:19]

Change committed as 95115