Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: ppapi/cpp/dev/scrollbar_dev.cc

Issue 7538006: Pepper and WebKit API change to support a plugin knowing if a scrollbar is an overlay one. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Get rid of ScrollbarGroup's methods and the ResizeClient interface Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/cpp/dev/scrollbar_dev.cc
===================================================================
--- ppapi/cpp/dev/scrollbar_dev.cc (revision 95420)
+++ ppapi/cpp/dev/scrollbar_dev.cc (working copy)
@@ -6,6 +6,7 @@
#include "ppapi/cpp/dev/scrollbar_dev.h"
+#include "ppapi/cpp/dev/scrollbar_group_dev.h"
#include "ppapi/cpp/instance.h"
#include "ppapi/cpp/module.h"
#include "ppapi/cpp/module_impl.h"
@@ -24,11 +25,14 @@
Scrollbar_Dev::Scrollbar_Dev(PP_Resource resource) : Widget_Dev(resource) {
}
-Scrollbar_Dev::Scrollbar_Dev(const Instance& instance, bool vertical) {
+Scrollbar_Dev::Scrollbar_Dev(const Instance& instance,
+ const ScrollbarGroup_Dev& scrollbar_group,
+ bool vertical) {
if (!has_interface<PPB_Scrollbar_Dev>())
return;
PassRefFromConstructor(get_interface<PPB_Scrollbar_Dev>()->Create(
- instance.pp_instance(), PP_FromBool(vertical)));
+ instance.pp_instance(), scrollbar_group.pp_resource(),
brettw 2011/08/08 20:22:47 This line should be indented 2 more spaces (aligne
+ PP_FromBool(vertical)));
}
Scrollbar_Dev::Scrollbar_Dev(const Scrollbar_Dev& other)
@@ -41,6 +45,13 @@
return get_interface<PPB_Scrollbar_Dev>()->GetThickness(pp_resource());
}
+bool Scrollbar_Dev::IsOverlay() {
+ if (!has_interface<PPB_Scrollbar_Dev>())
+ return false;
+ return
+ PP_ToBool(get_interface<PPB_Scrollbar_Dev>()->IsOverlay(pp_resource()));
+}
+
uint32_t Scrollbar_Dev::GetValue() {
if (!has_interface<PPB_Scrollbar_Dev>())
return 0;

Powered by Google App Engine
This is Rietveld 408576698