Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/WebKit/chromium/public/WebScrollbar.h

Issue 7538006: Pepper and WebKit API change to support a plugin knowing if a scrollbar is an overlay one. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Make scrollbars appear when chrome becomes active Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/WebKit/chromium/public/WebScrollbar.h
===================================================================
--- third_party/WebKit/Source/WebKit/chromium/public/WebScrollbar.h (revision 92488)
+++ third_party/WebKit/Source/WebKit/chromium/public/WebScrollbar.h (working copy)
@@ -34,9 +34,13 @@
#include "WebCanvas.h"
#include "WebCommon.h"
+// TODO(jam): take this out once Chrome rolls this revision of WebKit.
+#define WEBSCROLLBAR_SUPPORTS_OVERLAY
+
namespace WebKit {
class WebInputEvent;
+class WebPluginContainer;
class WebScrollbarClient;
struct WebRect;
@@ -59,14 +63,20 @@
ScrollByPixel
};
- // Creates a WebScrollbar.
- WEBKIT_EXPORT static WebScrollbar* create(WebScrollbarClient*, Orientation);
+ // Creates a WebScrollbar for use by a plugin. The plugin container and
+ // client are guaranteed to outlive this object.
+ WEBKIT_EXPORT static WebScrollbar* create(Orientation,
darin (slow to review) 2011/08/10 18:00:34 nit: Let's call this createForPlugin just to be a
+ WebPluginContainer*,
+ WebScrollbarClient*);
virtual ~WebScrollbar() {}
// Gets the thickness of the scrollbar in pixels.
WEBKIT_EXPORT static int defaultThickness();
+ // Return true if this is an overlay scrollbar.
+ virtual bool isOverlay() = 0;
darin (slow to review) 2011/08/10 18:00:34 can this be a const method? (like value())
+
// Sets the rectangle of the scrollbar.
virtual void setLocation(const WebRect&) = 0;

Powered by Google App Engine
This is Rietveld 408576698