Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: webkit/plugins/ppapi/ppb_scrollbar_impl.cc

Issue 7538006: Pepper and WebKit API change to support a plugin knowing if a scrollbar is an overlay one. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_scrollbar_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_scrollbar_impl.cc (revision 95011)
+++ webkit/plugins/ppapi/ppb_scrollbar_impl.cc (working copy)
@@ -48,10 +48,14 @@
return ::ppapi::thunk::GetPPB_Scrollbar_Thunk()->IsScrollbar(resource);
}
-uint32_t GetThickness() {
+uint32_t GetThickness3() {
return WebScrollbar::defaultThickness();
}
+uint32_t GetThickness4(PP_Resource resource) {
+ return ::ppapi::thunk::GetPPB_Scrollbar_Thunk()->GetThickness(resource);
+}
+
uint32_t GetValue(PP_Resource resource) {
return ::ppapi::thunk::GetPPB_Scrollbar_Thunk()->GetValue(resource);
}
@@ -82,7 +86,7 @@
const PPB_Scrollbar_0_3_Dev ppb_scrollbar_0_3 = {
&Create,
&IsScrollbar,
- &GetThickness,
+ &GetThickness3,
&GetValue,
&SetValue,
&SetDocumentSize,
@@ -90,6 +94,17 @@
&ScrollBy
};
+const PPB_Scrollbar_0_4_Dev ppb_scrollbar_0_4 = {
+ &Create,
+ &IsScrollbar,
+ &GetThickness4,
+ &GetValue,
+ &SetValue,
+ &SetDocumentSize,
+ &SetTickMarks,
+ &ScrollBy
+};
+
} // namespace
PPB_Scrollbar_Impl::PPB_Scrollbar_Impl(PluginInstance* instance, bool vertical)
@@ -111,10 +126,19 @@
return &ppb_scrollbar_0_3;
}
+// static
+const PPB_Scrollbar_0_4_Dev* PPB_Scrollbar_Impl::Get0_4Interface() {
+ return &ppb_scrollbar_0_4;
+}
+
uint32_t PPB_Scrollbar_Impl::GetThickness() {
return WebScrollbar::defaultThickness();
}
+bool PPB_Scrollbar_Impl::IsOverlay() {
+ return scrollbar_->isOverlay();
+}
+
uint32_t PPB_Scrollbar_Impl::GetValue() {
return scrollbar_->value();
}
@@ -204,6 +228,18 @@
instance()->pp_instance(), resource.id, scrollbar_->value());
}
+void PPB_Scrollbar_Impl::overlayChanged(WebScrollbar* scrollbar) {
+ const PPP_Scrollbar_Dev* ppp_scrollbar =
+ static_cast<const PPP_Scrollbar_Dev*>(instance()->module()->
+ GetPluginInterface(PPP_SCROLLBAR_DEV_INTERFACE));
+ if (!ppp_scrollbar)
+ return;
+ ScopedResourceId resource(this);
+ ppp_scrollbar->OverlayChanged(
+ instance()->pp_instance(), resource.id,
+ PP_FromBool(scrollbar_->isOverlay()));
+}
+
void PPB_Scrollbar_Impl::invalidateScrollbarRect(
WebKit::WebScrollbar* scrollbar,
const WebKit::WebRect& rect) {
« ppapi/c/dev/ppp_scrollbar_dev.h ('K') | « webkit/plugins/ppapi/ppb_scrollbar_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698