Apply the new asynchronous CookieMonster API to extension_service_unittest.cc.

Apply the new asynchronous CookieMonster API to extension_service_unittest.cc.
BUG=68657
TEST=XXXX

[ycxiao, 2011-08-02 20:52:26]

Hi Pawel,

PTAL.

Thanks!
Yancheng

[Paweł Hajdan Jr., 2011-08-02 21:43:23]

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service_unittest.cc:2677: 10);
Why PostDelayedTask instead of doing it immediately?

Also, this seems to be duplicating
src/chrome/browser/automation/automation_util.cc

How about ensuring we have only one copy of the code?

[ycxiao, 2011-08-02 23:00:24]

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service_unittest.cc:2677: 10);
On 2011/08/02 21:43:23, Paweł Hajdan Jr. wrote:
> Why PostDelayedTask instead of doing it immediately?
> 
> Also, this seems to be duplicating
> src/chrome/browser/automation/automation_util.cc
> 
> How about ensuring we have only one copy of the code?

The callback of CookieMonster may be invoked immediately or delayed depending on
whether cookies are loaded in memory. The PostDelayedTask is to make sure that
the MessageLoop:quit always happens after RunAllPending(). PostTask seems also
work. But I am not confident about that.

To using the automation_util.cc we need a TabContents pointer which we don't
have it here. Otherwise we need to change the automation_util.cc. And the change
not looks trivial for me. Since we only need two callbacks here, It may not
worth to do it.

How do you think about it?

Thanks!

[Paweł Hajdan Jr., 2011-08-02 23:29:59]

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service_unittest.cc:2677: 10);
On 2011/08/02 23:00:24, ycxiao wrote:
> On 2011/08/02 21:43:23, Paweł Hajdan Jr. wrote:
> > Why PostDelayedTask instead of doing it immediately?
> > 
> > Also, this seems to be duplicating
> > src/chrome/browser/automation/automation_util.cc
> > 
> > How about ensuring we have only one copy of the code?
> 
> The callback of CookieMonster may be invoked immediately or delayed depending
on
> whether cookies are loaded in memory. The PostDelayedTask is to make sure that
> the MessageLoop:quit always happens after RunAllPending(). PostTask seems also
> work. But I am not confident about that.

Okay just get rid of PostDelayedTask.

[ycxiao, 2011-08-03 00:21:11]

On 2011/08/02 23:29:59, Paweł Hajdan Jr. wrote:
>
http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_service_unittest.cc (right):
> 
>
http://codereview.chromium.org/7537039/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_service_unittest.cc:2677: 10);
> On 2011/08/02 23:00:24, ycxiao wrote:
> > On 2011/08/02 21:43:23, Paweł Hajdan Jr. wrote:
> > > Why PostDelayedTask instead of doing it immediately?
> > > 
> > > Also, this seems to be duplicating
> > > src/chrome/browser/automation/automation_util.cc
> > > 
> > > How about ensuring we have only one copy of the code?
> > 
> > The callback of CookieMonster may be invoked immediately or delayed
depending
> on
> > whether cookies are loaded in memory. The PostDelayedTask is to make sure
that
> > the MessageLoop:quit always happens after RunAllPending(). PostTask seems
also
> > work. But I am not confident about that.
> 
> Okay just get rid of PostDelayedTask.

Done the change. Move to the CL at http://codereview.chromium.org/7550020/.
Since I am traveling at mtv, I am not able to update this CL which is created at
my desktop.
Sorry for the inconvenience. Thanks!

Yancheng