Add a proxy for thread-hopping VideoCapture::EventHandler.

Add a proxy for thread-hopping VideoCapture::EventHandler.

BUG=None
TEST=Video Capture PPAPI example (in later CL)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95140

[piman, 2011-08-01 22:19:47]

This is CL 1 of 5 for adding a Video Capture Pepper API.

[wjia(left Chromium), 2011-08-02 00:10:39]

Nice! It's possible for CaptureVideoDecoder and VideoCaptureModuleImpl to use
this Proxy class.

http://codereview.chromium.org/7537037/diff/1/media/media.gyp
File media/media.gyp (right):

http://codereview.chromium.org/7537037/diff/1/media/media.gyp#newcode189
media/media.gyp:189: 'video/capture/video_capture_proxy.h',
h is after cc

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
File media/video/capture/video_capture_proxy.cc (right):

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.cc:30:
main_message_loop_(base::MessageLoopProxy::CreateForCurrentThread()) {
how about passing in main_message_loop as an argument? That allows more classes
to use this proxy if those classes only know their main working message loop.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.cc:38: this,
indentation.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
File media/video/capture/video_capture_proxy.h (right):

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:8: #include "base/compiler_specific.h"
not used, I think.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:10: #include "base/scoped_ptr.h"
this one is not used.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:22: // this class allows symless
proxying to another thread ("main thread"), which
seamless?

[piman, 2011-08-02 01:08:54]

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
File media/video/capture/video_capture_proxy.cc (right):

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.cc:30:
main_message_loop_(base::MessageLoopProxy::CreateForCurrentThread()) {
On 2011/08/02 00:10:39, wjia wrote:
> how about passing in main_message_loop as an argument? That allows more
classes
> to use this proxy if those classes only know their main working message loop.

I did that, if that is helpful to create this class on one thread but expect it
to forward to another thread. Note however possible subtle issues with lifetime,
since this class expects that the proxied event handler outlives it.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.cc:38: this,
On 2011/08/02 00:10:39, wjia wrote:
> indentation.

Done (here and below).

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
File media/video/capture/video_capture_proxy.h (right):

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:8: #include "base/compiler_specific.h"
On 2011/08/02 00:10:39, wjia wrote:
> not used, I think.

It's needed for the OVERRIDE's. That I somehow missed. I put them in, and left
this.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:10: #include "base/scoped_ptr.h"
On 2011/08/02 00:10:39, wjia wrote:
> this one is not used.

Done.

http://codereview.chromium.org/7537037/diff/1/media/video/capture/video_captu...
media/video/capture/video_capture_proxy.h:22: // this class allows symless
proxying to another thread ("main thread"), which
On 2011/08/02 00:10:39, wjia wrote:
> seamless?

Done.

[wjia(left Chromium), 2011-08-02 01:19:37]

LGTM.

[commit-bot: I haz the power, 2011-08-02 03:09:07]

Try job failure for 7537037-6001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-08-02 04:12:45]

Try job failure for 7537037-6001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-08-02 19:59:17]

Change committed as 95140