Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 7537028: Enabling 3 tests on windows as they are not failing anymore on the bot.

Created:
9 years, 4 months ago by shubho
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enabling 3 tests on windows as they dont fail anymore on the bot. BUG=54942, 50481 TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M functional/PYAUTO_TESTS View 2 chunks +0 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
anantha
LGTM
9 years, 4 months ago (2011-08-01 19:21:04 UTC) #1
Nirnimesh
http://codereview.chromium.org/7537028/diff/1/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (left): http://codereview.chromium.org/7537028/diff/1/functional/PYAUTO_TESTS#oldcode138 functional/PYAUTO_TESTS:138: # crbug.com/50481, crbug.com/54942 Please reference both these bug numbers ...
9 years, 4 months ago (2011-08-01 19:23:23 UTC) #2
shubho
Updated the description as suggested.
9 years, 4 months ago (2011-08-01 19:24:48 UTC) #3
Nirnimesh
LGTM. I'm assuming you've run these tests with --repeat=20 and seen them pass
9 years, 4 months ago (2011-08-01 20:13:36 UTC) #4
shubho
yes run with repeat 20 and works all the times.
9 years, 4 months ago (2011-08-01 20:24:30 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/test/functional/PYAUTO_TESTS. While running patch -p0 --forward --force; patching file chrome/test/functional/PYAUTO_TESTS ...
9 years, 4 months ago (2011-08-01 20:24:52 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/test/functional/PYAUTO_TESTS. While running patch -p0 --forward --force; patching file chrome/test/functional/PYAUTO_TESTS ...
9 years, 4 months ago (2011-08-03 20:26:30 UTC) #7
commit-bot: I haz the power
9 years, 4 months ago (2011-08-08 18:05:53 UTC) #8
Can't apply patch for file chrome/test/functional/PYAUTO_TESTS.
While running patch -p0 --forward --force;
patching file chrome/test/functional/PYAUTO_TESTS
Hunk #1 FAILED at 135.
Hunk #2 succeeded at 164 with fuzz 1 (offset 5 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/test/functional/PYAUTO_TESTS.rej

Powered by Google App Engine
This is Rietveld 408576698