Add new Content settings type AUTO-SUBMIT-CERTIFICATE

chrome/browser/tab_contents/tab_contents_ssl_helper.h

Index: chrome/browser/tab_contents/tab_contents_ssl_helper.h
diff --git a/chrome/browser/tab_contents/tab_contents_ssl_helper.h b/chrome/browser/tab_contents/tab_contents_ssl_helper.h
index 8ee4076fcc9c2163c8239414450983ad3d8f22fe..0614e9ba326e3ffffcf6b2d307a1d3340cc9fc06 100644
--- a/chrome/browser/tab_contents/tab_contents_ssl_helper.h
+++ b/chrome/browser/tab_contents/tab_contents_ssl_helper.h
@@ -20,10 +20,8 @@ class TabContentsSSLHelper {
   explicit TabContentsSSLHelper(TabContentsWrapper* tab_contents);
   virtual ~TabContentsSSLHelper();
 
-  // Displays a dialog to select client certificates from |request_info|,
-  // returning them to |handler|.
-  void ShowClientCertificateRequestDialog(
-      scoped_refptr<SSLClientAuthHandler> handler);
+  // Selects the client certificate to submit.
+  void SelectClientCertificate(scoped_refptr<SSLClientAuthHandler> handler);

[wtc, 2011/08/11 18:33:55]

Please add "and returns it to |handler|".  See also my comment
below.

[markusheintz_, 2011/08/15 19:09:04]

Done.

 
   // Called when |handler| encounters an error in verifying a received client
   // certificate. Note that, because CAs often will not send us intermediate
@@ -52,6 +50,11 @@ class TabContentsSSLHelper {
       scoped_refptr<SSLAddCertHandler> handler);
 
  private:
+  // Displays a dialog to select client certificates from |request_info|,
+  // returning them to |handler|.

[wtc, 2011/08/11 18:33:55]

Please update this (stale) comment because the |request_info|
argument is gone.

I think |request_info| is now a member of |handler|.

Also, the comment should say "select a client certificate"
and "returning it to |handler|".

[markusheintz_, 2011/08/15 19:09:04]

Done.

+  void ShowClientCertificateRequestDialog(
+      scoped_refptr<SSLClientAuthHandler> handler);
+
   TabContentsWrapper* tab_contents_;
 
   class SSLAddCertData;