Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 7536001: Re-land: Allow sync integration tests to operate on multiple datatypes: Autofill (Closed)

Created:
9 years, 4 months ago by Raghu Simha
Modified:
9 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Re-land: Allow sync integration tests to operate on multiple datatypes: Autofill The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes. This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Autofill datatype to the new model, and contains the following changes: - LiveAutofillSyncTest no longer inherits from LiveSyncTest, but is renamed to AutofillHelper, and contains a bunch of static methods that perform various operations related to Autofill. - TwoClientLiveAutofillSyncTest is renamed to TwoClientAutofillSyncTest, and is a subclass of LiveSyncTest. It uses the methods in AutofillHelper by including its header file and attaching itself to the helper. BUG=88510 TEST=sync_integration_tests, sync_performance_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95263 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95267 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95346

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase on trunk (once again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -855 lines) Patch
M chrome/browser/autofill/personal_data_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/test/live_sync/autofill_helper.h View 3 chunks +32 lines, -38 lines 0 comments Download
A + chrome/test/live_sync/autofill_helper.cc View 1 15 chunks +49 lines, -34 lines 0 comments Download
D chrome/test/live_sync/live_autofill_sync_test.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/test/live_sync/live_autofill_sync_test.cc View 1 1 chunk +0 lines, -294 lines 0 comments Download
M chrome/test/live_sync/performance/autofill_sync_perf_test.cc View 1 2 6 chunks +24 lines, -19 lines 0 comments Download
A chrome/test/live_sync/two_client_autofill_sync_test.cc View 1 chunk +437 lines, -0 lines 0 comments Download
D chrome/test/live_sync/two_client_live_autofill_sync_test.cc View 1 chunk +0 lines, -360 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
tim: main reviewer. nzea: backup reviewer in case tim can't get to this. Please review. ...
9 years, 4 months ago (2011-07-29 10:47:14 UTC) #1
Raghu Simha
Bumping this in the hope that someone gets to look at it on Monday :)
9 years, 4 months ago (2011-08-01 05:30:57 UTC) #2
Raghu Simha
Nicolas, you're it now. Thanks for the review.
9 years, 4 months ago (2011-08-02 21:03:52 UTC) #3
Nicolas Zea
9 years, 4 months ago (2011-08-02 23:22:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698