Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 7535006: Add acquire/release calls in one-time init for histograms (Closed)

Created:
9 years, 4 months ago by jar (doing other things)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Add acquire/release calls in one-time init for histograms Clean up macros which do one-time initialization of static pointer to histograms to use subtle atomic operators. r=willchan, dvyukov BUG=7535006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95762

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -93 lines) Patch
M base/metrics/histogram.h View 1 2 3 4 5 6 6 chunks +110 lines, -93 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jar (doing other things)
As per the associated bug, the approach taken is to just add the subtle operations.
9 years, 4 months ago (2011-08-04 22:27:23 UTC) #1
dvyukov
LGTM +1 for comments and refactoring
9 years, 4 months ago (2011-08-05 14:07:27 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 4 months ago (2011-08-05 20:50:03 UTC) #3
jar (doing other things)
I was told by the commit bot that I needed an LGTM from an OWNER..... ...
9 years, 4 months ago (2011-08-05 21:06:45 UTC) #4
jar (doing other things)
wtc, Could you review and/or rubber stamp this? It has an LGTM from dvyukov, who ...
9 years, 4 months ago (2011-08-06 16:39:01 UTC) #5
willchan no longer on Chromium
Rubberstamp LGTM On Sat, Aug 6, 2011 at 5:39 PM, <jar@chromium.org> wrote: > wtc, > ...
9 years, 4 months ago (2011-08-06 23:00:23 UTC) #6
commit-bot: I haz the power
9 years, 4 months ago (2011-08-07 02:47:57 UTC) #7
Can't apply patch for file base/metrics/histogram.h.
While running patch -p0 --forward --force;
patching file base/metrics/histogram.h
Hunk #1 FAILED at 45.
1 out of 6 hunks FAILED -- saving rejects to file base/metrics/histogram.h.rej

Powered by Google App Engine
This is Rietveld 408576698