cloud_print/virtual_driver/win/port_monitor/port_monitor.cc - Issue 7532031: Changes to write various registry keys as required by Omaha for Windows Cloud Print Virtual Driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

Issue 7532031: Changes to write various registry keys as required by Omaha for Windows Cloud Print Virtual Driver. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixes as per code review. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cloud_print/virtual_driver/win/install/setup.cc ('K') | « cloud_print/virtual_driver/win/install/setup.cc ('k') | cloud_print/virtual_driver/win/virtual_driver_consts.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

diff --git a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

index 562d0b8dea617b4b4ac3d32929d46b3c981eccd7..5faa7847346a48095d18c7c3be2486f4ed3f82e9 100644

--- a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

+++ b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

@@ -380,6 +380,16 @@ BOOL WINAPI Monitor2StartDocPort(HANDLE port_handle,

DWORD,

BYTE*) {

LOG(INFO) << "Monitor2StartDocPort";

+ const wchar_t* kUsageKey = L"dr";

+ // Set appropriate key to 1 to let Omaha record usage.

+ base::win::RegKey key;

+ if (key.Create(HKEY_CURRENT_USER, kKeyLocation,

+ KEY_SET_VALUE) != ERROR_SUCCESS) {

+ LOG(ERROR) << "Unable to open key to log usage";

+ }

+ if (key.WriteValue(kUsageKey, L"1") != ERROR_SUCCESS) {

+ LOG(ERROR) << "Unable to set usage key";

+ }

if (port_handle == NULL) {

LOG(ERROR) << "port_handle should not be NULL.";

SetLastError(ERROR_INVALID_PARAMETER);