Changes to write various registry keys as required by Omaha for Windows Cloud Print Virtual Driver.

Changes to write various registry keys as required by Omaha for Windows Cloud Print Virtual Driver.


BUG=
TEST= 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97434

[Albert Bodenhamer, 2011-07-29 21:43:48]

LGTM
Please fix lint errors we discussed and the minor issues below before submit.

Also, since I'm not a full-committer you'll need an LG from Scott or Sanjeev as
well.

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/install/setup.cc:47: version_string = L"1.9.8.3";
Use 0.0.0.99 or something like it.  1.9.8.3 might someday be a real version
number.

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:10: #include
<userenv.h>
Add registry include file.

[abeera, 2011-07-29 21:53:40]

Done, lint errors fixed as well.

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7532031/diff/7/cloud_print/virtual_driver/win/...
cloud_print/virtual_driver/win/install/setup.cc:47: version_string = L"1.9.8.3";
On 2011/07/29 21:43:48, Albert Bodenhamer wrote:
> Use 0.0.0.99 or something like it.  1.9.8.3 might someday be a real version
> number.

Done.

[sanjeevr, 2011-08-03 11:19:29]

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:23: const wchar_t* kVersionKey =
L"pv";
It is the norm in Chrome to use const wchar_t[] instead of const wchar_t*.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:30: KEY_ALL_ACCESS) !=
ERROR_SUCCESS) {
You don't need KEY_ALL_ACCESS here. You just need KEY_SET_VALUE.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:50: key.WriteValue(kNameKey,
L"GCP Virtual Driver") != ERROR_SUCCESS ||
Why don't you create constant strings for these as well?

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:59: KEY_ALL_ACCESS) !=
ERROR_SUCCESS) {
Again you only need DELETE access. And you don't need to call Create, just Open.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:387: KEY_ALL_ACCESS)
!= ERROR_SUCCESS) {
You only need KEY_SET_VALUE.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/virtual_driver_consts.h (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/virtual_driver_consts.h:12: extern const wchar_t*
kKeyLocation;
Again use const wchar_t []

[abeera, 2011-08-03 19:50:30]

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:23: const wchar_t* kVersionKey =
L"pv";
On 2011/08/03 11:19:29, sanjeevr wrote:
> It is the norm in Chrome to use const wchar_t[] instead of const wchar_t*.

Done.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:30: KEY_ALL_ACCESS) !=
ERROR_SUCCESS) {
On 2011/08/03 11:19:29, sanjeevr wrote:
> You don't need KEY_ALL_ACCESS here. You just need KEY_SET_VALUE.

Done.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:50: key.WriteValue(kNameKey,
L"GCP Virtual Driver") != ERROR_SUCCESS ||
On 2011/08/03 11:19:29, sanjeevr wrote:
> Why don't you create constant strings for these as well?

Done.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:59: KEY_ALL_ACCESS) !=
ERROR_SUCCESS) {
On 2011/08/03 11:19:29, sanjeevr wrote:
> Again you only need DELETE access. And you don't need to call Create, just
Open.

Done.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:387: KEY_ALL_ACCESS)
!= ERROR_SUCCESS) {
On 2011/08/03 11:19:29, sanjeevr wrote:
> You only need KEY_SET_VALUE.

Done.

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/virtual_driver_consts.h (right):

http://codereview.chromium.org/7532031/diff/8001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/virtual_driver_consts.h:12: extern const wchar_t*
kKeyLocation;
On 2011/08/03 11:19:29, sanjeevr wrote:
> Again use const wchar_t []

Done.

[sanjeevr, 2011-08-08 07:51:31]

LGTM

http://codereview.chromium.org/7532031/diff/12001/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7532031/diff/12001/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/setup.cc:61: DELETE) != ERROR_SUCCESS) {
Nit: Indentation.

[commit-bot: I haz the power, 2011-08-19 05:46:13]

Change committed as 97434