Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Side by Side Diff: net/proxy/proxy_service.h

Issue 7532011: Only mark a proxy as bad if we have confirmation that another proxy succeeded for the same request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/proxy/proxy_list.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_SERVICE_H_ 5 #ifndef NET_PROXY_PROXY_SERVICE_H_
6 #define NET_PROXY_PROXY_SERVICE_H_ 6 #define NET_PROXY_PROXY_SERVICE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 // 90 //
91 // Returns ERR_FAILED if there is not another proxy config to try. 91 // Returns ERR_FAILED if there is not another proxy config to try.
92 // 92 //
93 // Profiling information for the request is saved to |net_log| if non-NULL. 93 // Profiling information for the request is saved to |net_log| if non-NULL.
94 int ReconsiderProxyAfterError(const GURL& url, 94 int ReconsiderProxyAfterError(const GURL& url,
95 ProxyInfo* results, 95 ProxyInfo* results,
96 CompletionCallback* callback, 96 CompletionCallback* callback,
97 PacRequest** pac_request, 97 PacRequest** pac_request,
98 const BoundNetLog& net_log); 98 const BoundNetLog& net_log);
99 99
100 // Called to report that the last proxy connection succeeded. If |proxy_info|
101 // has a non empty proxy_retry_info map, the proxies that have been tried (and
102 // failed) for this request will be marked as bad.
103 void ReportSuccess(const ProxyInfo& proxy_info);
104
100 // Call this method with a non-null |pac_request| to cancel the PAC request. 105 // Call this method with a non-null |pac_request| to cancel the PAC request.
101 void CancelPacRequest(PacRequest* pac_request); 106 void CancelPacRequest(PacRequest* pac_request);
102 107
103 // Sets the ProxyScriptFetcher and DhcpProxyScriptFetcher dependencies. This 108 // Sets the ProxyScriptFetcher and DhcpProxyScriptFetcher dependencies. This
104 // is needed if the ProxyResolver is of type ProxyResolverWithoutFetch. 109 // is needed if the ProxyResolver is of type ProxyResolverWithoutFetch.
105 // ProxyService takes ownership of both objects. 110 // ProxyService takes ownership of both objects.
106 void SetProxyScriptFetchers( 111 void SetProxyScriptFetchers(
107 ProxyScriptFetcher* proxy_script_fetcher, 112 ProxyScriptFetcher* proxy_script_fetcher,
108 DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher); 113 DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher);
109 ProxyScriptFetcher* GetProxyScriptFetcher() const; 114 ProxyScriptFetcher* GetProxyScriptFetcher() const;
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 395
391 base::WaitableEvent event_; 396 base::WaitableEvent event_;
392 CompletionCallbackImpl<SyncProxyServiceHelper> callback_; 397 CompletionCallbackImpl<SyncProxyServiceHelper> callback_;
393 ProxyInfo proxy_info_; 398 ProxyInfo proxy_info_;
394 int result_; 399 int result_;
395 }; 400 };
396 401
397 } // namespace net 402 } // namespace net
398 403
399 #endif // NET_PROXY_PROXY_SERVICE_H_ 404 #endif // NET_PROXY_PROXY_SERVICE_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_list.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698