Only mark a proxy as bad if we have confirmation that another proxy succeeded for the same request.

jingle/notifier/base/proxy_resolving_client_socket.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/base/proxy_resolving_client_socket.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "googleurl/src/gurl.h"
@@ skipping 172 matching lines @@
     // If the connection fails, try another proxy.
     status = ReconsiderProxyAfterError(status);
     // ReconsiderProxyAfterError either returns an error (in which case it is
     // not reconsidering a proxy) or returns ERR_IO_PENDING if it is considering
     // another proxy.
     DCHECK_NE(status, net::OK);
     if (status == net::ERR_IO_PENDING)
       // Proxy reconsideration pending. Return.
       return;
     CloseTransportSocket();
+  } else {
+    ReportSuccessfulProxyConnection();
   }
   RunUserConnectCallback(status);
 }
 
 // TODO(sanjeevr): This has largely been copied from
 // HttpStreamFactoryImpl::Job::ReconsiderProxyAfterError. This should be
 // refactored into some common place.
 // This method reconsiders the proxy on certain errors. If it does reconsider
 // a proxy it always returns ERR_IO_PENDING and posts a call to
 // ProcessProxyResolveDone with the result of the reconsideration.
@@ skipping 64 matching lines @@
         FROM_HERE,
         scoped_runnable_method_factory_.NewRunnableMethod(
             &ProxyResolvingClientSocket::ProcessProxyResolveDone, rv));
     // Since we potentially have another try to go (trying the direct connect)
     // set the return code code to ERR_IO_PENDING.
     rv = net::ERR_IO_PENDING;
   }
   return rv;
 }
 
+void ProxyResolvingClientSocket::ReportSuccessfulProxyConnection() {
+  network_session_->proxy_service()->ReportSuccess(proxy_info_);
+}
+
 void ProxyResolvingClientSocket::Disconnect() {
   CloseTransportSocket();
   if (pac_request_)
     network_session_->proxy_service()->CancelPacRequest(pac_request_);
   user_connect_callback_ = NULL;
 }
 
 bool ProxyResolvingClientSocket::IsConnected() const {
   if (!transport_.get() || !transport_->socket())
     return false;
@@ skipping 71 matching lines @@
   return base::TimeDelta::FromMicroseconds(-1);
 }
 
 void ProxyResolvingClientSocket::CloseTransportSocket() {
   if (transport_.get() && transport_->socket())
     transport_->socket()->Disconnect();
   transport_.reset();
 }
 
 }  // namespace notifier