Fix the issue that keyboard is not rendered properly after login.

Fix the issue that keyboard is not rendered properly after login.

Setting className of the keyboard is deferred until window.onhashchange but early exit in onhashchange caused the class of keyboard to remain nodisplay.
This change modify the initKeyboard to set the className.

BUG=none
TEST=Manually checked the keyboard was shown properly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95387

[bryeung, 2011-08-03 21:11:41]

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:128: keyboardDiv.className =
'keyboard';
the keyboard should ideally not be visible until it has been properly sized: I
want to avoid the case where the keyboard is rendered at a wrong size and then
changes size in a way that is visible to the user.

[mazda, 2011-08-04 04:28:50]

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:128: keyboardDiv.className =
'keyboard';
On 2011/08/03 21:11:42, bryeung wrote:
> the keyboard should ideally not be visible until it has been properly sized: I
> want to avoid the case where the keyboard is rendered at a wrong size and then
> changes size in a way that is visible to the user.

The keyboard is not visible at least until its node is appended to the document
node in line 133.
I haven't thoroughly looked into Webkit code so I'm not 100% sure, but the
renderer should show the correctly sized keyboard when element.appendChild is
called. As far as I tested on a seaboard, it worked that way.

[bryeung, 2011-08-04 04:36:50]

LGTM

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7531026/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:128: keyboardDiv.className =
'keyboard';
On 2011/08/04 04:28:50, mazda wrote:
> On 2011/08/03 21:11:42, bryeung wrote:
> > the keyboard should ideally not be visible until it has been properly sized:
I
> > want to avoid the case where the keyboard is rendered at a wrong size and
then
> > changes size in a way that is visible to the user.
> 
> The keyboard is not visible at least until its node is appended to the
document
> node in line 133.
> I haven't thoroughly looked into Webkit code so I'm not 100% sure, but the
> renderer should show the correctly sized keyboard when element.appendChild is
> called. As far as I tested on a seaboard, it worked that way.

Yes: that makes sense.  Thanks for the clarification.

[commit-bot: I haz the power, 2011-08-04 06:10:34]

Change committed as 95387