chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm - Issue 7530024: bookmarks: Simplify is_permanent_node() implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 7530024: bookmarks: Simplify is_permanent_node() implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sky review -> is_root_node Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

index 8d0d9bc8b303483528ee2bb75d0e5803e15c1b95..fb6eabec8f6f49d9c1c5189ec5e89a3b50613636 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

@@ -378,7 +378,7 @@ void BookmarkBubbleNotificationBridge::Observe(

- (void)addFolderNodes:(const BookmarkNode*)parent

toPopUpButton:(NSPopUpButton*)button

indentation:(int)indentation {

- if (!model_->is_root(parent)) {

+ if (parent != model_->root_node()) {

sky 2011/07/29 19:30:28 Use is_root_node

tfarina 2011/07/29 19:39:36 Done.

NSString* title = base::SysUTF16ToNSString(parent->GetTitle());

NSMenu* menu = [button menu];

NSMenuItem* item = [menu addItemWithTitle:title

« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.cc ('k') | no next file » | no next file with comments »