Added PPB_Graphics3D_Dev::Resize to let plugins resize the backing surface.

content/renderer/pepper_platform_context_3d_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper_platform_context_3d_impl.h"
 
 #include "content/renderer/render_thread.h"
 #include "content/renderer/gpu/renderer_gl_context.h"
 #include "content/renderer/gpu/gpu_channel_host.h"
 #include "content/renderer/gpu/command_buffer_proxy.h"
@@ skipping 22 matching lines @@
 
   if (command_buffer_) {
     DCHECK(channel_.get());
     channel_->DestroyCommandBuffer(command_buffer_);
     command_buffer_ = NULL;
   }
 
   channel_ = NULL;
 }
 
-bool PlatformContext3DImpl::Init() {
+bool PlatformContext3DImpl::Init(const int32* attrib_list) {
   // Ignore initializing more than once.
   if (command_buffer_)
     return true;
 
   // Parent may already have been deleted.
   if (!parent_context_.get())
     return false;
 
   RenderThread* render_thread = RenderThread::current();
   if (!render_thread)
     return false;
 
   channel_ = render_thread->GetGpuChannel();
   if (!channel_.get())
     return false;
 
   DCHECK(channel_->state() == GpuChannelHost::kConnected);
 
   // Flush any remaining commands in the parent context to make sure the
   // texture id accounting stays consistent.
   gpu::gles2::GLES2Implementation* parent_gles2 =
       parent_context_->GetImplementation();
   parent_gles2->helper()->CommandBufferHelper::Finish();
   parent_texture_id_ = parent_gles2->MakeTextureId();
 
-  // TODO(apatrick): Let Pepper plugins configure their back buffer surface.
+  // TODO(alokp): Remove this when we deprecate PPB_Context3D.
   static const int32 kAttribs[] = {
     RendererGLContext::ALPHA_SIZE, 8,
     RendererGLContext::DEPTH_SIZE, 24,
     RendererGLContext::STENCIL_SIZE, 8,
     RendererGLContext::SAMPLES, 0,
     RendererGLContext::SAMPLE_BUFFERS, 0,
+    RendererGLContext::HEIGHT, 1,
+    RendererGLContext::WIDTH, 1,
     RendererGLContext::NONE,
   };

[piman, 2011/07/28 23:35:06]

You could move this to PPB_Context3D_Impl

[alokp, 2011/07/29 16:13:12]

Good idea. Done.

-  std::vector<int32> attribs(kAttribs, kAttribs + ARRAYSIZE_UNSAFE(kAttribs));
+  attrib_list = attrib_list ? attrib_list : kAttribs;
+
+  gfx::Size surface_size;
+  std::vector<int32> attribs;
+  for (const int32_t* attr = attrib_list;
+       attr[0] != RendererGLContext::NONE;
+       attr += 2) {
+    switch (attr[0]) {
+      case RendererGLContext::WIDTH:
+        surface_size.set_width(attr[1]);
+        break;
+      case RendererGLContext::HEIGHT:
+        surface_size.set_height(attr[1]);
+        break;
+      default:
+        attribs.push_back(attr[0]);
+        attribs.push_back(attr[1]);
+        break;
+    }
+  }
+  attribs.push_back(RendererGLContext::NONE);
+
   CommandBufferProxy* parent_command_buffer =
       parent_context_->GetCommandBufferProxy();
   command_buffer_ = channel_->CreateOffscreenCommandBuffer(
-      gfx::Size(1, 1),
+      surface_size,
       "*",
       attribs,
       GURL::EmptyGURL());
   if (!command_buffer_)
     return false;
 
   if (!command_buffer_->SetParent(parent_command_buffer, parent_texture_id_))
     return false;
 
   command_buffer_->SetChannelErrorCallback(callback_factory_.NewCallback(
@@ skipping 26 matching lines @@
 }
 
 void PlatformContext3DImpl::OnContextLost() {
   DCHECK(command_buffer_);
 
   if (context_lost_callback_.get())
     context_lost_callback_->Run();
 }
 
 #endif  // ENABLE_GPU