Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 7529051: ntp: use web store as default mv tile instead of themes gallery (Closed)

Created:
9 years, 4 months ago by Evan Stade
Modified:
9 years, 4 months ago
Reviewers:
csilv
CC:
chromium-reviews, estade+watch_chromium.org, finnur+watch_chromium.org, arv (Not doing code reviews), jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

ntp: use web store as default mv tile instead of themes gallery BUG=90558 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96040

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated thumbnail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 chunk +5 lines, -0 lines 0 comments Download
D chrome/app/theme/ntp_store_thumb.png View Binary file 0 comments Download
D chrome/app/theme/ntp_themes_gallery_thumb.png View Binary file 0 comments Download
A chrome/app/theme/ntp_webstore_thumb.png View 1 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
9 years, 4 months ago (2011-08-09 18:04:16 UTC) #1
csilv
Is the new thumbnail included here desired? I ask because the app shown is from ...
9 years, 4 months ago (2011-08-09 19:11:19 UTC) #2
csilv
lgtm, see comments.
9 years, 4 months ago (2011-08-09 19:11:38 UTC) #3
Evan Stade
Cole actually wants something "custom", what that means is TBD, so this is just a ...
9 years, 4 months ago (2011-08-09 19:18:02 UTC) #4
Evan Stade
9 years, 4 months ago (2011-08-09 19:19:40 UTC) #5
although that screenshot is out of date so I might as well update it

Powered by Google App Engine
This is Rietveld 408576698