Fixed playing multiple files in the mediaplayer.

Fixed playing multiple files in the mediaplayer.

BUG=chromium-os:17610, chromium-os:18965
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97126

[Vladislav Kaznacheev, 2011-08-10 13:34:57]

http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
File chrome/browser/chromeos/media/media_player.cc (right):

http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
chrome/browser/chromeos/media/media_player.cc:121: current_playlist_.clear();
This seriously changes the behavior. Does the bug require that?

http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1060: // The
first one need to be forced to play.
need -> needs. Maybe rewrite a comment to be more clear.

[SeRya, 2011-08-10 15:51:00]

http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
File chrome/browser/chromeos/media/media_player.cc (right):

http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
chrome/browser/chromeos/media/media_player.cc:121: current_playlist_.clear();
On 2011/08/10 13:34:58, Vladislav Kaznacheev wrote:
> This seriously changes the behavior. Does the bug require that? 

This change solves a separate problems and I filed another issue. It clears
playlist on click the Play button in the file manager or click on a file in the
dowsnloads page.

http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1060: // The
first one need to be forced to play.
On 2011/08/10 13:34:58, Vladislav Kaznacheev wrote:
> need -> needs. Maybe rewrite a comment to be more clear.

Rewritten.

[Vladislav Kaznacheev, 2011-08-10 16:13:18]

LGTM

On 2011/08/10 15:51:00, SeRya wrote:
>
http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
> File chrome/browser/chromeos/media/media_player.cc (right):
> 
>
http://codereview.chromium.org/7529048/diff/1/chrome/browser/chromeos/media/m...
> chrome/browser/chromeos/media/media_player.cc:121: current_playlist_.clear();
> On 2011/08/10 13:34:58, Vladislav Kaznacheev wrote:
> > This seriously changes the behavior. Does the bug require that? 
> 
> This change solves a separate problems and I filed another issue. It clears
> playlist on click the Play button in the file manager or click on a file in
the
> dowsnloads page.
> 
>
http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_file_browser_private_api.cc (right):
> 
>
http://codereview.chromium.org/7529048/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_file_browser_private_api.cc:1060: // The
> first one need to be forced to play.
> On 2011/08/10 13:34:58, Vladislav Kaznacheev wrote:
> > need -> needs. Maybe rewrite a comment to be more clear.
> 
> Rewritten.

[commit-bot: I haz the power, 2011-08-17 10:31:13]

Change committed as 97126