Issue 7529038: chromeos: Minor changes to volume/brightness bubble UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7529038: chromeos: Minor changes to volume/brightness bubble UI. (Closed)

Created:
9 years, 4 months ago by Daniel Erat

Modified:
9 years, 4 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

chromeos: Minor changes to volume/brightness bubble UI. This makes the bubbles ten pixels shorter and implements the Bubble class's fade-in/fade-out behavior for GTK+ (which also e.g. makes bookmark bubbles now fade away when you click their "Done" buttons or "Remove" links, like on other platforms). BUG=chromium-os:8473 TEST=manual: configured the setting bubbles to fade in and out and checked that they looked correct Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96004

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	chrome/browser/chromeos/setting_level_bubble.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bubble/bubble.cc	View	6 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages