Issue 7529031: NativeWidgetPrivate::CreateNativeWidget should check for NULL on views_delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7529031: NativeWidgetPrivate::CreateNativeWidget should check for NULL on views_delegate (Closed)

Created:
9 years, 4 months ago by varunjain

Modified:
9 years, 4 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, dhollowa

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

NativeWidgetPrivate::CreateNativeWidget should check for NULL on views_delegate as views_delegate may not be initialized when touchui is set BUG=none. TEST=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95940

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	views/widget/native_widget_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

sadrul

LGTM. Perhaps add a note that views_delegate can be NULL for unit_tests.

9 years, 4 months ago (2011-08-08 21:52:43 UTC) #2

LGTM