Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: chrome/browser/extensions/extension_install_ui.h

Issue 7529011: Add a flag that lets the webstore show a different UI on app install. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed files added in separate CL (r95432) Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_install_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_ui.h
diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h
index 19965e5fed35c71d1db5b884599131b4ef4d8a5f..4ce572085ee4b05119c4932fce1f380bb4987c97 100644
--- a/chrome/browser/extensions/extension_install_ui.h
+++ b/chrome/browser/extensions/extension_install_ui.h
@@ -15,6 +15,7 @@
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/native_widget_types.h"
+class Browser;
class Extension;
class ExtensionPermissionSet;
class MessageLoop;
@@ -56,6 +57,14 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer {
explicit ExtensionInstallUI(Profile* profile);
virtual ~ExtensionInstallUI();
+ // TODO(asargent) Normally we navigate to the new tab page when an app is
+ // installed, but we're experimenting with instead showing a bubble when
+ // an app is installed which points to the new tab button. This may become
+ // the default behavior in the future.
+ void set_use_app_installed_bubble(bool use_bubble) {
+ use_app_installed_bubble_ = use_bubble;
+ }
+
// This is called by the installer to verify whether the installation should
// proceed. This is declared virtual for testing.
//
@@ -86,6 +95,10 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer {
virtual void OnImageLoaded(
SkBitmap* image, const ExtensionResource& resource, int index);
+ // Opens a new tab page and animates the app icon for the app with id
+ // |app_id|.
+ static void OpenAppInstalledNTP(Browser* browser, const std::string& app_id);
+
protected:
friend class ExtensionWebstorePrivateApiTest;
@@ -145,6 +158,10 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer {
// Keeps track of extension images being loaded on the File thread for the
// purpose of showing the install UI.
ImageLoadingTracker tracker_;
+
+ // Whether to show an installed bubble on app install, or use the default
+ // action of opening a new tab page.
+ bool use_app_installed_bubble_;
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_UI_H_
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_install_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698