Updated demo to use resizable plugin element. This exercises the new PPB_Graphics3D_Dev::Resize()...

Updated demo to use resizable plugin element. This exercises the new PPB_Graphics3D_Dev::Resize() API.
BUG=62383
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95134

[apatrick_chromium, 2011-07-28 22:05:54]

LGTM

[piman, 2011-07-28 22:09:24]

LGTM on the C++ code, I'm curious about the HTML/JS bits....

http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html
File gpu/demos/pepper_gpu_demo.html (right):

http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html#...
gpu/demos/pepper_gpu_demo.html:34: resizePlugin();
Why is this logic needed ? Setting the plugin's width/height to 100% of the
container should work, no ?

[alokp, 2011-07-28 22:28:45]

http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html
File gpu/demos/pepper_gpu_demo.html (right):

http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html#...
gpu/demos/pepper_gpu_demo.html:34: resizePlugin();
On 2011/07/28 22:09:24, piman wrote:
> Why is this logic needed ? Setting the plugin's width/height to 100% of the
> container should work, no ?

I tried 100% initially, but the plugin was still overflowing out of the
container. CSS spec also says that height/width for a embed tag can only be
specified in pixels. The code above worked so I did not pay much attention to
it.

[piman, 2011-07-28 22:37:49]

On Thu, Jul 28, 2011 at 3:28 PM, <alokp@chromium.org> wrote:

>
> http://codereview.chromium.**org/7529009/diff/1/gpu/demos/**
>
pepper_gpu_demo.html<http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html>
> File gpu/demos/pepper_gpu_demo.html (right):
>
> http://codereview.chromium.**org/7529009/diff/1/gpu/demos/**
>
pepper_gpu_demo.html#newcode34<http://codereview.chromium.org/7529009/diff/1/gpu/demos/pepper_gpu_demo.html#newcode34>
> gpu/demos/pepper_gpu_demo.**html:34: resizePlugin();
> On 2011/07/28 22:09:24, piman wrote:
>
>> Why is this logic needed ? Setting the plugin's width/height to 100%
>>
> of the
>
>> container should work, no ?
>>
>
> I tried 100% initially, but the plugin was still overflowing out of the
> container. CSS spec also says that height/width for a embed tag can only
> be specified in pixels. The code above worked so I did not pay much
> attention to it.


Ok, LGTM then...

Antoine


>
>
>
http://codereview.chromium.**org/7529009/<http://codereview.chromium.org/7529...
>