Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2308)

Unified Diff: base/timer_unittest.cc

Issue 7529003: Make base::MessageLoops have names at construction time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add name argument to MessageLoop Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/timer_unittest.cc
diff --git a/base/timer_unittest.cc b/base/timer_unittest.cc
index 79d3a4e65ec3f3dc1f6a09e8408850b09cbacf90..61f89ca1e845657972a2b5ad872e95c62dc3a184 100644
--- a/base/timer_unittest.cc
+++ b/base/timer_unittest.cc
@@ -75,7 +75,7 @@ class RepeatingTimerTester {
};
void RunTest_OneShotTimer(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
bool did_run = false;
OneShotTimerTester f(&did_run);
@@ -87,7 +87,7 @@ void RunTest_OneShotTimer(MessageLoop::Type message_loop_type) {
}
void RunTest_OneShotTimer_Cancel(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
bool did_run_a = false;
OneShotTimerTester* a = new OneShotTimerTester(&did_run_a);
@@ -109,7 +109,7 @@ void RunTest_OneShotTimer_Cancel(MessageLoop::Type message_loop_type) {
}
void RunTest_OneShotSelfDeletingTimer(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
bool did_run = false;
OneShotSelfDeletingTimerTester f(&did_run);
@@ -121,7 +121,7 @@ void RunTest_OneShotSelfDeletingTimer(MessageLoop::Type message_loop_type) {
}
void RunTest_RepeatingTimer(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
bool did_run = false;
RepeatingTimerTester f(&did_run);
@@ -133,7 +133,7 @@ void RunTest_RepeatingTimer(MessageLoop::Type message_loop_type) {
}
void RunTest_RepeatingTimer_Cancel(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
bool did_run_a = false;
RepeatingTimerTester* a = new RepeatingTimerTester(&did_run_a);
@@ -172,7 +172,7 @@ class DelayTimerTarget {
};
void RunTest_DelayTimer_NoCall(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
// If Delay is never called, the timer shouldn't go off.
DelayTimerTarget target;
@@ -188,7 +188,7 @@ void RunTest_DelayTimer_NoCall(MessageLoop::Type message_loop_type) {
}
void RunTest_DelayTimer_OneCall(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
DelayTimerTarget target;
base::DelayTimer<DelayTimerTarget> timer(
@@ -221,7 +221,7 @@ struct ResetHelper {
};
void RunTest_DelayTimer_Reset(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
// If Delay is never called, the timer shouldn't go off.
DelayTimerTarget target;
@@ -254,7 +254,7 @@ class DelayTimerFatalTarget {
void RunTest_DelayTimer_Deleted(MessageLoop::Type message_loop_type) {
- MessageLoop loop(message_loop_type);
+ MessageLoop loop("TimerTest", message_loop_type);
DelayTimerFatalTarget target;
@@ -345,7 +345,7 @@ TEST(TimerTest, MessageLoopShutdown) {
OneShotTimerTester c(&did_run);
OneShotTimerTester d(&did_run);
{
- MessageLoop loop(MessageLoop::TYPE_DEFAULT);
+ MessageLoop loop("TimerTest", MessageLoop::TYPE_DEFAULT);
a.Start();
b.Start();
} // MessageLoop destructs by falling out of scope.

Powered by Google App Engine
This is Rietveld 408576698