Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: base/observer_list_unittest.cc

Issue 7529003: Make base::MessageLoops have names at construction time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add name argument to MessageLoop Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/observer_list_unittest.cc
diff --git a/base/observer_list_unittest.cc b/base/observer_list_unittest.cc
index d0d2001e3f8dc0465b0236a702b56b192227ba3f..fcdcd84c3f068805dda8df00679d3e76c0e064be 100644
--- a/base/observer_list_unittest.cc
+++ b/base/observer_list_unittest.cc
@@ -107,7 +107,7 @@ class AddRemoveThread : public PlatformThread::Delegate,
}
void ThreadMain() {
- loop_ = new MessageLoop(); // Fire up a message loop.
+ loop_ = new MessageLoop("ThreadMain"); // Fire up a message loop.
loop_->PostTask(
FROM_HERE, factory_->NewRunnableMethod(&AddRemoveThread::AddTask));
loop_->Run();
@@ -200,7 +200,7 @@ TEST(ObserverListTest, BasicTest) {
}
TEST(ObserverListThreadSafeTest, BasicTest) {
- MessageLoop loop;
+ MessageLoop loop("ObserverListThreadSafeTest");
scoped_refptr<ObserverListThreadSafe<Foo> > observer_list(
new ObserverListThreadSafe<Foo>);
@@ -230,7 +230,7 @@ TEST(ObserverListThreadSafeTest, BasicTest) {
}
TEST(ObserverListThreadSafeTest, RemoveObserver) {
- MessageLoop loop;
+ MessageLoop loop("ObserverListThreadSafeTest");
scoped_refptr<ObserverListThreadSafe<Foo> > observer_list(
new ObserverListThreadSafe<Foo>);
@@ -282,7 +282,7 @@ class FooRemover : public Foo {
};
TEST(ObserverListThreadSafeTest, RemoveMultipleObservers) {
- MessageLoop loop;
+ MessageLoop loop("ObserverListThreadSafeTest");
scoped_refptr<ObserverListThreadSafe<Foo> > observer_list(
new ObserverListThreadSafe<Foo>);
@@ -306,7 +306,7 @@ TEST(ObserverListThreadSafeTest, RemoveMultipleObservers) {
// all observers.
static void ThreadSafeObserverHarness(int num_threads,
bool cross_thread_notifies) {
- MessageLoop loop;
+ MessageLoop loop("ThreadSafeObserverHarness");
const int kMaxThreads = 15;
num_threads = num_threads > kMaxThreads ? kMaxThreads : num_threads;

Powered by Google App Engine
This is Rietveld 408576698